Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/add initial files #1

Merged
merged 25 commits into from
Apr 4, 2024
Merged

Task/add initial files #1

merged 25 commits into from
Apr 4, 2024

Conversation

ckunki
Copy link
Collaborator

@ckunki ckunki commented Apr 3, 2024

No description provided.

@ahsimb
Copy link
Contributor

ahsimb commented Apr 4, 2024

Should the namespace be more specific, e.g. "saas_client" or "saas_api_python"?

@ckunki
Copy link
Collaborator Author

ckunki commented Apr 4, 2024

Should the namespace be more specific, e.g. "saas_client" or "saas_api_python"?

"Python" I think is clear from the context, as it is a python namespace and not a java one.

Imagining using the API, I assume a developer would prefer writing something like saas.connect() rather than saas_client.connect().

But maybe, later on, we might create a class Client in saas.client, which is not prevented by the initial repository layout.

@ahsimb
Copy link
Contributor

ahsimb commented Apr 4, 2024

I agree that the word "python" is not needed. Longer names in the import are usually not a problem as you can use short aliases. I just thought it would be good to distinguish between the backend and the client namespaces. But I guess exasol.saas.client will work just as well.

@ckunki ckunki merged commit 4f0c485 into main Apr 4, 2024
6 checks passed
@ckunki ckunki deleted the task/add_initial_files branch April 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants