Skip to content

Commit

Permalink
Doc/updated testing instructions (#58)
Browse files Browse the repository at this point in the history
* Update testing instructions in developer guide
* Upload openapi.json in GitHub workflow
* Updated actions/checkout@v3 to v4
* Added option overwrite when uploading coverage
  • Loading branch information
ckunki authored May 29, 2024
1 parent 5db4f4a commit 1d64153
Show file tree
Hide file tree
Showing 10 changed files with 31 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:

- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand Down
19 changes: 14 additions & 5 deletions .github/workflows/check-api-outdated.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Check if OpenAPI is Outdated
name: Open API

on:
push:
Expand All @@ -16,19 +16,28 @@ on:
jobs:

check-api-outdated:
name: Check if OpenAPI Generated From JSON is Outdated
name: Check API Outdated
runs-on: ubuntu-latest
strategy:
fail-fast: false

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Display branch
- name: Display Branch and Download openapi.json
id: download
run: |
git branch
curl -s https://cloud.exasol.com/openapi.json
F="ci-$(date "+%y%m%d-%H%M").json"
curl -s https://cloud.exasol.com/openapi.json -o "$F"
echo json=$F >> "$GITHUB_OUTPUT"
- name: Upload openapi.json
uses: actions/upload-artifact@v4
with:
name: ${{ steps.download.outputs.json}}
path: ${{ steps.download.outputs.json}}

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-release-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -27,7 +27,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand All @@ -47,7 +47,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand All @@ -68,7 +68,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: ./.github/workflows/report.yml

gate-1:
name: Regular
name: Gate 1 - Regular CI
needs: [ ci-job ]
runs-on: ubuntu-latest
steps:
Expand All @@ -49,7 +49,7 @@ jobs:
python-version: "3.10"

gate-2:
name: Merge
name: Gate 2 - Allow Merge
runs-on: ubuntu-latest
needs: [ run-slow-tests ]
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: SCM Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ jobs:
with:
name: .coverage
path: .coverage
overwrite: true
5 changes: 5 additions & 0 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
## Refactoring

* #53: Separated long-running tests
* Updated GitHub workflow to upload `openapi.json` as artifact

## Features

* #55 Added publicly callable function finding the database id from its name.

## Documentation

* Updated instructions for triggering slow tests in Developer Guide
2 changes: 1 addition & 1 deletion doc/developer_guide/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Executing the integration tests requires the following environment variables to

Some of the test cases verify connecting to a SaaS database instance and execution will take about 20 minutes.

These test cases are disabled by default and will only be executed by adding a comment `[run-slow-tests]` to your pull request.
The regular CI build will ask for a confirmation (aka. "review) before executing these tests.

## Creating a Release

Expand Down

0 comments on commit 1d64153

Please sign in to comment.