#74,75 Creating and using bucket-fs connection objects #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # exasol/python_extension_common/deployment/language_container_deployer.py # exasol/python_extension_common/deployment/language_container_deployer_cli.py # pyproject.toml # test/unit/deployment/test_language_container_deployer.py # test/unit/deployment/test_language_container_deployer_cli.py
…connection-object
Nicoretti
previously approved these changes
Oct 4, 2024
|
|
||
|
|
||
| @dataclass | ||
| class ConnObjectData: |
There was a problem hiding this comment.
Suggested change
| class ConnObjectData: | |
| class ConnectionInfo: |
Comment on lines
70
to
72
| bfs_path.write(TEST_FILE_CONTENT) | ||
| try: | ||
| yield |
There was a problem hiding this comment.
Suggested change
| bfs_path.write(TEST_FILE_CONTENT) | |
| try: | |
| yield | |
| try: | |
| bfs_path.write(TEST_FILE_CONTENT) | |
| yield |
Comment on lines
105
to
106
| if not use_saas: | ||
| pytest.skip("The test is not configured to use SaaS.") |
There was a problem hiding this comment.
Is it possible to achieve this decorator based?
There was a problem hiding this comment.
Possibly, but it's not trivial, as we need to look at the fixture.
Nicoretti
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #74
closes #75