#52: Added CLI options for specifying the timeout for the ExtractValidator #57
Conversation
and changed extract-timeout to be specified in minutes with default 5 minutes.
| @@ -306,7 +310,10 @@ def create(cls, | |||
| path_in_bucket: str = '', | |||
| use_ssl_cert_validation: bool = True, ssl_trusted_ca: Optional[str] = None, | |||
| ssl_client_certificate: Optional[str] = None, | |||
| ssl_private_key: Optional[str] = None) -> "LanguageContainerDeployer": | |||
| ssl_private_key: Optional[str] = None, | |||
| extract_timeout: timedelta = timedelta(seconds=10), | |||
There was a problem hiding this comment.
A proper value for a timeout is beyond 10 minutes
There was a problem hiding this comment.
I will set it to 10 minutes, see next push.
| @@ -152,6 +153,9 @@ def secret_callback(ctx: click.Context, param: click.Option, value: Any): | |||
| @click.option('--alter-system/--no-alter-system', type=bool, default=True) | |||
| @click.option('--allow-override/--disallow-override', type=bool, default=False) | |||
| @click.option('--wait_for_completion/--no-wait_for_completion', type=bool, default=True) | |||
| @click.option('--extract-timeout-minutes', type=int, default=5) | |||
There was a problem hiding this comment.
I would set the default at least to 10 minutes
| @@ -87,6 +87,10 @@ def get_udf_path(bucket_base_path: bfs.path.PathLike, bucket_file: str) -> PureP | |||
| return PurePosixPath(file_path.as_udf_path()) | |||
|
|
|||
|
|
|||
| def display_extract_progress(n: int, pending: List[int]): | |||
There was a problem hiding this comment.
How often would this be called?
There was a problem hiding this comment.
It depends on the settings.
- timeout by default is now updated to 10 minutes, can be changed via CLI
- interval currently, is always set to 10 seconds, not configurable via CLI
So with these setting, by default the callback will be called 10*60/10 = 60 times at max.
There was a problem hiding this comment.
I probably, would increase the interval to 30 seconds
There was a problem hiding this comment.
Thanks - changed in latest push.
|
I am not sure if the term |
Yes, I think that is a good idea |
ckunki
deleted the
feature/#52-Added_timeout_options_for_SLC_deployer_to_CLI
branch
Closes #52