#5 Addressed review issues

exasol · May 15, 2024 · 6b6f4da · 6b6f4da
1 parent 7c3a3f8
commit 6b6f4da
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -103,13 +103,13 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Checkout ITDE
-        run: git clone https://github.com/exasol/integration-test-docker-environment.git
-        working-directory: ..
+      # - name: Checkout ITDE
+      #   run: git clone https://github.com/exasol/integration-test-docker-environment.git
+      #   working-directory: ..
 
-      - name: Start EXASOL Test-Environment
-        run: ./start-test-env spawn-test-environment --environment-name test --database-port-forward 8888 --bucketfs-port-forward 6666 --db-mem-size 4GB
-        working-directory: ../integration-test-docker-environment
+      # - name: Start EXASOL Test-Environment
+      #   run: ./start-test-env spawn-test-environment --environment-name test --database-port-forward 8888 --bucketfs-port-forward 6666 --db-mem-size 4GB
+      #   working-directory: ../integration-test-docker-environment
 
       - name: Calculate Test Coverage
         run: poetry run nox -s coverage -- -- --db-version ${{ matrix.exasol-version }}

diff --git a/test/__init__.py b/test/__init__.py
@@ -0,0 +1,4 @@
+import pytest
+
+
+pytest.register_assert_rewrite("test.utils.db_utils")
diff --git a/test/integration/test_language_container_deployer.py b/test/integration/test_language_container_deployer.py
@@ -30,6 +30,7 @@ def create_container_deployer(language_alias: str,
 
 
 def test_language_container_deployer(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
@@ -54,6 +55,7 @@ def test_language_container_deployer(
 
 
 def test_language_container_deployer_alter_session(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
@@ -84,6 +86,7 @@ def test_language_container_deployer_alter_session(
 
 
 def test_language_container_deployer_activation_fail(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,

diff --git a/test/integration/test_language_container_deployer_cli.py b/test/integration/test_language_container_deployer_cli.py
@@ -1,6 +1,5 @@
 from typing import Optional, Callable
 from contextlib import ExitStack
-from pathlib import Path
 
 from urllib.parse import urlparse
 from _pytest.fixtures import FixtureRequest
@@ -57,6 +56,7 @@ def call_language_definition_deployer_cli(func,
 
 
 def test_language_container_deployer_cli_with_container_file(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
@@ -84,6 +84,7 @@ def test_language_container_deployer_cli_with_container_file(
 
 
 def test_language_container_deployer_cli_by_downloading_container(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
@@ -111,6 +112,7 @@ def test_language_container_deployer_cli_by_downloading_container(
 
 
 def test_language_container_deployer_cli_with_missing_container_option(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
@@ -131,6 +133,7 @@ def test_language_container_deployer_cli_with_missing_container_option(
 
 
 def test_language_container_deployer_cli_with_check_cert(
+        itde,
         request: FixtureRequest,
         connection_factory: Callable[[config.Exasol], ExaConnection],
         exasol_config: config.Exasol,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		import pytest


		pytest.register_assert_rewrite("test.utils.db_utils")