Add test for concurrent access on connection #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
requested changes
Jun 20, 2024
test/integration/concurrency_test.py
Outdated
| def run(self): | ||
| try: | ||
| # run heavy query | ||
| self.connection.execute("SELECT * FROM users a, users b, users c, payments d") |
There was a problem hiding this comment.
Could the query be simplified?
Or is there a specific reason for querying table users 3 times?
There was a problem hiding this comment.
took this from the original example, see comment above.
I assume this shall make sure query does take long enough for the second attempt.
Maybe it can be done with a sleep, I'll try.
There was a problem hiding this comment.
Previously "sleep" UDFs did not work well with abort_query() call. Usually it caused an entire connection to be terminated.
There was a problem hiding this comment.
@littleK0i from what I have seen with Exasol >= 7.1, sleep works fine.
With this information which query would you prefer and why?
Nicoretti
force-pushed
the
test/add-concurrency-test-case
branch
from
c8b1f80 to
1eece36
Compare
ckunki
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.