Skip to content

Commit

Permalink
Don't include Oracle JDBC driver in packaged JAR
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada committed Nov 8, 2023
1 parent 8b278e8 commit d67cb4a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions doc/changes/changes_2.4.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ Code name: Test with Exasol 8

This release adds integration tests using Exasol 8.

**Note:** This release removes the Oracle JDBC driver from the adapter JAR file that was accidentally included in version 2.1.0. This means that you will need to define the `ADAPTER SCRIPT` specifying both the adapter JAR and the JDBC driver JAR as described in the [user guide](../user_guide/oracle_user_guide.md#installing-the-adapter-script).

## Feature

* #33: Added tests with Exasol 8
Expand Down
5 changes: 2 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@
<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ojdbc8</artifactId>
<version>23.3.0.23.09</version>
<!-- This must be in compile scope to avoid the following error when creating the virtual schema:
"java.sql.SQLException: No suitable driver found for jdbc:oracle:thin:@172.17.0.1:32805/xepdb1" -->
<scope>compile</scope>
<!-- This must be in test scope to avoid including the driver in the built JAR. -->
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.exasol</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ public static void uploadOracleJDBCDriverAndVSToBucket(final Bucket bucket)

public static AdapterScript createAdapterScript(final ExasolSchema schema) {
final String content = "%scriptclass com.exasol.adapter.RequestDispatcher;\n" //
+ "%jar /buckets/bfsdefault/default/" + VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION + ";\n";
+ "%jar /buckets/bfsdefault/default/" + VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION + ";\n" //
+ "%jar /buckets/bfsdefault/default/drivers/jdbc/ojdbc8.jar;\n";
return schema.createAdapterScript(ADAPTER_SCRIPT_EXASOL, JAVA, content);
}

Expand Down

0 comments on commit d67cb4a

Please sign in to comment.