Skip to content

Commit

Permalink
Review findings
Browse files Browse the repository at this point in the history
  • Loading branch information
chiaradiamarcelo committed Jan 12, 2021
1 parent d650cf9 commit 7545d6b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 18 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Running the Virtual Schema requires a Java Runtime version 11 or later.
| [Exasol Virtual Schema JDBC][virtual-schema-common-jdbc] | Common JDBC functions for Virtual Schemas adapters | MIT License |
| [Oracle JDBC Driver][oracle-jdbc-driver] | JDBC driver for Oracle database | Oracle Technology Network License |
| [Exasol Error Reporting][exasol-error-reporting] | Creating unified error messages | MIT License |
| [Exasol Database Fundamentals for Java][exasol-db-funtamentals] | Base objects and ground rules for the Exasol database | MIT License |

### Test Dependencies

Expand All @@ -61,7 +62,7 @@ Running the Virtual Schema requires a Java Runtime version 11 or later.
| [Exasol Testcontainers][exasol-testcontainers] | Exasol extension for the Testcontainers framework | MIT License |
| [Test Database Builder][test-db-builder] | Fluent database interfaces for testing | MIT License |
| [Exasol Hamcrest Result Set Matcher][exasol-hamcrest] | Hamcrest result set matcher for testing | MIT License |
| [Exasol UDF Debugging][udf-debugging-java] | Debugging UDFs in testing | MIT License |
| [EqualsVerifier][jqno-equals-verifier] | Testing `hashCode` and `equals` Java contract | Apache-2.0 License |


### Maven Plug-ins
Expand All @@ -83,11 +84,12 @@ Running the Virtual Schema requires a Java Runtime version 11 or later.
[virtual-schema-common-jdbc]: https://github.com/exasol/virtual-schema-common-jdbc
[oracle-jdbc-driver]: https://www.oracle.com/database/technologies/appdev/jdbc.html
[exasol-error-reporting]: https://github.com/exasol/error-reporting-java/
[exasol-db-funtamentals]: https://github.com/exasol/db-fundamentals-java/

[exasol-testcontainers]: https://github.com/exasol/exasol-testcontainers
[test-db-builder]: https://github.com/exasol/test-db-builder/
[exasol-hamcrest]: https://github.com/exasol/hamcrest-resultset-matcher
[udf-debugging-java]: https://github.com/exasol/udf-debugging-java
[jqno-equals-verifier]: https://github.com/jqno/equalsverifier

[maven-jacoco-plugin]: https://www.eclemma.org/jacoco/trunk/doc/maven.html
[maven-surefire-plugin]: https://maven.apache.org/surefire/maven-surefire-plugin/
Expand Down
1 change: 0 additions & 1 deletion doc/changes/changes_1.0.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Code name: Migration from the virtual-schemas repository
* Added `org.hamcrest:hamcrest:2.2`
* Added `org.junit.jupiter:junit-jupiter:5.7.0`
* Added `org.mockito:mockito-junit-jupiter:3.6.28`
* Added `junit:junit:4.13.1`
* Added `nl.jqno.equalsverifier:equalsverifier:3.5`
* Added `com.exasol:exasol-testcontainers:3.3.1`
* Added `org.testcontainers:junit-jupiter:1.15.0`
Expand Down
15 changes: 0 additions & 15 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@
<version>3.6.28</version>
<scope>test</scope>
</dependency>
<!-- Overrides Junit 4.12 which is used in test containers but contains
a security issue: https://ossindex.sonatype.org/vuln/7ea56ad4-8a8b-4e51-8ed9-5aad83d8efb1 -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>nl.jqno.equalsverifier</groupId>
<artifactId>equalsverifier</artifactId>
Expand Down Expand Up @@ -314,13 +306,6 @@
</goals>
</execution>
</executions>
<configuration>
<excludeVulnerabilityIds>
<!-- Ignores CVE-2020-15250, because we use Java 11 and junit 4.13.1
which contains a fix: https://ossindex.sonatype.org/vuln/7ea56ad4-8a8b-4e51-8ed9-5aad83d8efb1 -->
<exclude>7ea56ad4-8a8b-4e51-8ed9-5aad83d8efb1</exclude>
</excludeVulnerabilityIds>
</configuration>
</plugin>
</plugins>
</build>
Expand Down

0 comments on commit 7545d6b

Please sign in to comment.