Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using config enumeration internally #61

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Using config enumeration internally #61

merged 7 commits into from
Jan 16, 2024

Conversation

ahsimb
Copy link
Collaborator

@ahsimb ahsimb commented Jan 12, 2024

closes #60

@ahsimb ahsimb added the refactoring Code improvement without behavior change label Jan 12, 2024
@ahsimb ahsimb self-assigned this Jan 12, 2024
@ahsimb ahsimb changed the base branch from main to feature/47-sagemaker-ext-wrapper January 12, 2024 17:09
Nicoretti
Nicoretti approved these changes Jan 15, 2024
View reviewed changes
exasol/connections.py Show resolved Hide resolved
exasol/extension_wrapper_common.py Show resolved Hide resolved
exasol/transformers_extension_wrapper.py Show resolved Hide resolved
@Nicoretti Nicoretti self-assigned this Jan 15, 2024
@ahsimb
Copy link
Collaborator Author

ahsimb commented Jan 15, 2024

I think keeping two sets of unique entities in the config enum - names and values - is a bit silly. It is also confusing. So I left just one - the name. It is now used as the key in the secret store.

@ahsimb ahsimb merged commit 32ad969 into feature/47-sagemaker-ext-wrapper Jan 16, 2024
12 checks passed
@ahsimb ahsimb deleted the refactoring/60-use-ailabconfig branch January 16, 2024 15:49
ahsimb added a commit that referenced this pull request Jan 16, 2024
@ahsimb @tkilias
Sagemaker extension wrapper (#57)
1dd3ccb 
* Added the sagemaker extension wrapper

* Updated extension_wrapper_common.py

* Fixing the integration test

* Update exasol/sagemaker_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Typo and lock

* Using config enumeration internally (#61)

* Using AILabConfig internally

* Fixing errors picked by mypy

* Using config.name instead of the value

* Added aws_role to the AILabConfig

* Advanced the version to 0.2.6 (#64)

* Added aws_role to the AILabConfig

* Rolling back the adulteration by nox

---------

Co-authored-by: Torsten Kilias <[email protected]>
ahsimb added a commit that referenced this pull request Jan 16, 2024
@ahsimb @Shmuma @tkilias
Transformers extension wrapper (#56)
624cec7 
* Added the transformers extension wrapper

* Move setup code from cloud-storage notebooks to lib (#41)

* Github get version and dl url

* Requests types for types checking

* Retrieve jar function and tests

* Small comment

* BFS upload function, no tests

* BFS basic test

* BFS bucket mocking

* Unused import

* Cloud storage extension scripts

* Make lint happy

* #44: Added ITDE manager (#49)

Co-authored-by: Torsten Kilias <[email protected]>

* Fixing the integration test

* Updating poetry lock

* Changing the scope of the itde fixture

* Update exasol/transformers_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Added upload_model function

* Fixing typo

* Getting the mypy shut up

* Sagemaker extension wrapper (#57)

* Added the sagemaker extension wrapper

* Updated extension_wrapper_common.py

* Fixing the integration test

* Update exasol/sagemaker_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Typo and lock

* Using config enumeration internally (#61)

* Using AILabConfig internally

* Fixing errors picked by mypy

* Using config.name instead of the value

* Added aws_role to the AILabConfig

* Advanced the version to 0.2.6 (#64)

* Added aws_role to the AILabConfig

* Rolling back the adulteration by nox

---------

Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
ahsimb added a commit that referenced this pull request Jan 16, 2024
@ahsimb @Shmuma @tkilias
Unified language activation SQL command (#55)
221a1ba 
* Added language_container_activation module

* Transformers extension wrapper (#56)

* Added the transformers extension wrapper

* Move setup code from cloud-storage notebooks to lib (#41)

* Github get version and dl url

* Requests types for types checking

* Retrieve jar function and tests

* Small comment

* BFS upload function, no tests

* BFS basic test

* BFS bucket mocking

* Unused import

* Cloud storage extension scripts

* Make lint happy

* #44: Added ITDE manager (#49)

Co-authored-by: Torsten Kilias <[email protected]>

* Fixing the integration test

* Updating poetry lock

* Changing the scope of the itde fixture

* Update exasol/transformers_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Added upload_model function

* Fixing typo

* Getting the mypy shut up

* Sagemaker extension wrapper (#57)

* Added the sagemaker extension wrapper

* Updated extension_wrapper_common.py

* Fixing the integration test

* Update exasol/sagemaker_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Typo and lock

* Using config enumeration internally (#61)

* Using AILabConfig internally

* Fixing errors picked by mypy

* Using config.name instead of the value

* Added aws_role to the AILabConfig

* Advanced the version to 0.2.6 (#64)

* Added aws_role to the AILabConfig

* Rolling back the adulteration by nox

---------

Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
ahsimb added a commit that referenced this pull request Jan 16, 2024
@ahsimb @Nicoretti
@Shmuma @tkilias
Refactoring/52 data conv utility (#53)
9c142ed 
* Moved optional_str_to_bool to utils.py

* Update exasol/utils.py

Co-authored-by: Nicola Coretti <[email protected]>

* Unified language activation SQL command (#55)

* Added language_container_activation module

* Transformers extension wrapper (#56)

* Added the transformers extension wrapper

* Move setup code from cloud-storage notebooks to lib (#41)

* Github get version and dl url

* Requests types for types checking

* Retrieve jar function and tests

* Small comment

* BFS upload function, no tests

* BFS basic test

* BFS bucket mocking

* Unused import

* Cloud storage extension scripts

* Make lint happy

* #44: Added ITDE manager (#49)

Co-authored-by: Torsten Kilias <[email protected]>

* Fixing the integration test

* Updating poetry lock

* Changing the scope of the itde fixture

* Update exasol/transformers_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Added upload_model function

* Fixing typo

* Getting the mypy shut up

* Sagemaker extension wrapper (#57)

* Added the sagemaker extension wrapper

* Updated extension_wrapper_common.py

* Fixing the integration test

* Update exasol/sagemaker_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Typo and lock

* Using config enumeration internally (#61)

* Using AILabConfig internally

* Fixing errors picked by mypy

* Using config.name instead of the value

* Added aws_role to the AILabConfig

* Advanced the version to 0.2.6 (#64)

* Added aws_role to the AILabConfig

* Rolling back the adulteration by nox

---------

Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Nicola Coretti <[email protected]>
Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
ahsimb added a commit that referenced this pull request Jan 17, 2024
@ahsimb @Nicoretti
@Shmuma @tkilias
Made secret store iterable (#51)
84b86a4 
* Made secret store iterable

* Refactoring/52 data conv utility (#53)

* Moved optional_str_to_bool to utils.py

* Update exasol/utils.py

Co-authored-by: Nicola Coretti <[email protected]>

* Unified language activation SQL command (#55)

* Added language_container_activation module

* Transformers extension wrapper (#56)

* Added the transformers extension wrapper

* Move setup code from cloud-storage notebooks to lib (#41)

* Github get version and dl url

* Requests types for types checking

* Retrieve jar function and tests

* Small comment

* BFS upload function, no tests

* BFS basic test

* BFS bucket mocking

* Unused import

* Cloud storage extension scripts

* Make lint happy

* #44: Added ITDE manager (#49)

Co-authored-by: Torsten Kilias <[email protected]>

* Fixing the integration test

* Updating poetry lock

* Changing the scope of the itde fixture

* Update exasol/transformers_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Added upload_model function

* Fixing typo

* Getting the mypy shut up

* Sagemaker extension wrapper (#57)

* Added the sagemaker extension wrapper

* Updated extension_wrapper_common.py

* Fixing the integration test

* Update exasol/sagemaker_extension_wrapper.py

Co-authored-by: Torsten Kilias <[email protected]>

* Typo and lock

* Using config enumeration internally (#61)

* Using AILabConfig internally

* Fixing errors picked by mypy

* Using config.name instead of the value

* Added aws_role to the AILabConfig

* Advanced the version to 0.2.6 (#64)

* Added aws_role to the AILabConfig

* Rolling back the adulteration by nox

---------

Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Nicola Coretti <[email protected]>
Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>

---------

Co-authored-by: Nicola Coretti <[email protected]>
Co-authored-by: Max Lapan <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

Assignees

@Nicoretti Nicoretti

@ahsimb ahsimb

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start using the AILabConfig internally
2 participants
@ahsimb @Nicoretti