-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sagemaker extension wrapper #57
Merged
ahsimb
merged 10 commits into
feature/46-transformers-ext-wrapper
from
feature/47-sagemaker-ext-wrapper
Jan 16, 2024
Merged
Sagemaker extension wrapper #57
ahsimb
merged 10 commits into
feature/46-transformers-ext-wrapper
from
feature/47-sagemaker-ext-wrapper
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsimb
changed the base branch from
main
to
feature/46-transformers-ext-wrapper
January 9, 2024 14:39
…gemaker-ext-wrapper
…gemaker-ext-wrapper # Conflicts: # poetry.lock # pyproject.toml
…gemaker-ext-wrapper
tkilias
requested changes
Jan 16, 2024
Co-authored-by: Torsten Kilias <[email protected]>
…' into feature/47-sagemaker-ext-wrapper
tkilias
approved these changes
Jan 16, 2024
ckunki
requested changes
Jan 16, 2024
) | ||
from exasol.extension_wrapper_common import ( | ||
encapsulate_aws_credentials, | ||
str_to_bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
str_to_bool | |
str_to_bool, |
) | ||
from exasol.language_container_activation import ( | ||
ACTIVATION_KEY_PREFIX, | ||
get_activation_sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
get_activation_sql | |
get_activation_sql, |
Parameters: | ||
conf: | ||
The secret store. The store should contain all the required | ||
parameters for accessing the database, bucket-fs and AWS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
parameters for accessing the database, bucket-fs and AWS. | |
parameters for accessing the database, BucketFS, and AWS. |
ckunki
approved these changes
Jan 16, 2024
* Using AILabConfig internally * Fixing errors picked by mypy * Using config.name instead of the value * Added aws_role to the AILabConfig * Advanced the version to 0.2.6 (#64) * Added aws_role to the AILabConfig * Rolling back the adulteration by nox
ahsimb
added a commit
that referenced
this pull request
Jan 16, 2024
* Added the transformers extension wrapper * Move setup code from cloud-storage notebooks to lib (#41) * Github get version and dl url * Requests types for types checking * Retrieve jar function and tests * Small comment * BFS upload function, no tests * BFS basic test * BFS bucket mocking * Unused import * Cloud storage extension scripts * Make lint happy * #44: Added ITDE manager (#49) Co-authored-by: Torsten Kilias <[email protected]> * Fixing the integration test * Updating poetry lock * Changing the scope of the itde fixture * Update exasol/transformers_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Added upload_model function * Fixing typo * Getting the mypy shut up * Sagemaker extension wrapper (#57) * Added the sagemaker extension wrapper * Updated extension_wrapper_common.py * Fixing the integration test * Update exasol/sagemaker_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Typo and lock * Using config enumeration internally (#61) * Using AILabConfig internally * Fixing errors picked by mypy * Using config.name instead of the value * Added aws_role to the AILabConfig * Advanced the version to 0.2.6 (#64) * Added aws_role to the AILabConfig * Rolling back the adulteration by nox --------- Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]>
ahsimb
added a commit
that referenced
this pull request
Jan 16, 2024
* Added language_container_activation module * Transformers extension wrapper (#56) * Added the transformers extension wrapper * Move setup code from cloud-storage notebooks to lib (#41) * Github get version and dl url * Requests types for types checking * Retrieve jar function and tests * Small comment * BFS upload function, no tests * BFS basic test * BFS bucket mocking * Unused import * Cloud storage extension scripts * Make lint happy * #44: Added ITDE manager (#49) Co-authored-by: Torsten Kilias <[email protected]> * Fixing the integration test * Updating poetry lock * Changing the scope of the itde fixture * Update exasol/transformers_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Added upload_model function * Fixing typo * Getting the mypy shut up * Sagemaker extension wrapper (#57) * Added the sagemaker extension wrapper * Updated extension_wrapper_common.py * Fixing the integration test * Update exasol/sagemaker_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Typo and lock * Using config enumeration internally (#61) * Using AILabConfig internally * Fixing errors picked by mypy * Using config.name instead of the value * Added aws_role to the AILabConfig * Advanced the version to 0.2.6 (#64) * Added aws_role to the AILabConfig * Rolling back the adulteration by nox --------- Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]>
ahsimb
added a commit
that referenced
this pull request
Jan 16, 2024
* Moved optional_str_to_bool to utils.py * Update exasol/utils.py Co-authored-by: Nicola Coretti <[email protected]> * Unified language activation SQL command (#55) * Added language_container_activation module * Transformers extension wrapper (#56) * Added the transformers extension wrapper * Move setup code from cloud-storage notebooks to lib (#41) * Github get version and dl url * Requests types for types checking * Retrieve jar function and tests * Small comment * BFS upload function, no tests * BFS basic test * BFS bucket mocking * Unused import * Cloud storage extension scripts * Make lint happy * #44: Added ITDE manager (#49) Co-authored-by: Torsten Kilias <[email protected]> * Fixing the integration test * Updating poetry lock * Changing the scope of the itde fixture * Update exasol/transformers_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Added upload_model function * Fixing typo * Getting the mypy shut up * Sagemaker extension wrapper (#57) * Added the sagemaker extension wrapper * Updated extension_wrapper_common.py * Fixing the integration test * Update exasol/sagemaker_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Typo and lock * Using config enumeration internally (#61) * Using AILabConfig internally * Fixing errors picked by mypy * Using config.name instead of the value * Added aws_role to the AILabConfig * Advanced the version to 0.2.6 (#64) * Added aws_role to the AILabConfig * Rolling back the adulteration by nox --------- Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Nicola Coretti <[email protected]> Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]>
ahsimb
added a commit
that referenced
this pull request
Jan 17, 2024
* Made secret store iterable * Refactoring/52 data conv utility (#53) * Moved optional_str_to_bool to utils.py * Update exasol/utils.py Co-authored-by: Nicola Coretti <[email protected]> * Unified language activation SQL command (#55) * Added language_container_activation module * Transformers extension wrapper (#56) * Added the transformers extension wrapper * Move setup code from cloud-storage notebooks to lib (#41) * Github get version and dl url * Requests types for types checking * Retrieve jar function and tests * Small comment * BFS upload function, no tests * BFS basic test * BFS bucket mocking * Unused import * Cloud storage extension scripts * Make lint happy * #44: Added ITDE manager (#49) Co-authored-by: Torsten Kilias <[email protected]> * Fixing the integration test * Updating poetry lock * Changing the scope of the itde fixture * Update exasol/transformers_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Added upload_model function * Fixing typo * Getting the mypy shut up * Sagemaker extension wrapper (#57) * Added the sagemaker extension wrapper * Updated extension_wrapper_common.py * Fixing the integration test * Update exasol/sagemaker_extension_wrapper.py Co-authored-by: Torsten Kilias <[email protected]> * Typo and lock * Using config enumeration internally (#61) * Using AILabConfig internally * Fixing errors picked by mypy * Using config.name instead of the value * Added aws_role to the AILabConfig * Advanced the version to 0.2.6 (#64) * Added aws_role to the AILabConfig * Rolling back the adulteration by nox --------- Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Nicola Coretti <[email protected]> Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> --------- Co-authored-by: Nicola Coretti <[email protected]> Co-authored-by: Max Lapan <[email protected]> Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #47