Spike: Temporary storage for a secret store password.

exasol/shared_memory_vault.py

@@ -0,0 +1,248 @@
+from typing import Optional, Tuple
+from multiprocessing.shared_memory import SharedMemory
+from math import ceil
+from datetime import datetime
+import struct
+
+
+DEFAULT_CRC_DIVISOR = '1001011001100101'
+DEFAULT_MAX_SIZE = 100
+DEFAULT_STORAGE_NAME = 'notebook_connector_vault'
+
+
+def _xor(sequence: str, crc_divisor: str) -> str:
+    return ''.join('0' if a == b else '1' for a, b in zip(sequence, crc_divisor))
+
+
+def compute_crc(sequence: str, crc_divisor: str) -> str:
+    """
+    Computes a Cyclic Redundancy Check (CRC) code for a provided binary sequence using
+    a provided polynomial divisor.
+    Check this wiki for details: https://en.wikipedia.org/wiki/Cyclic_redundancy_check
+    For example if the sequence is '11010011101100000' and the divisor is '011' the
+    output crc code will be '100'. Note that the n+1 bit long divisor, commonly used in
+    literature, 1011 in the above example, is assumed to have the most significant bit
+    (MSB) equal 1. Here the MSB is omitted.
+    """
+    n = len(crc_divisor)
+    reminder = sequence[:n]
+    for i in range(n, len(sequence)):
+        starts_one = reminder[0] == '1'
+        reminder = reminder[1:] + sequence[i]
+        if starts_one:
+            reminder = _xor(reminder, crc_divisor)
+    return reminder
+
+
+def _get_byte_size(n: int) -> int:
+    """Returns the number of bytes required to store an integer value"""
+    return int(ceil(n.bit_length() / 8))
+
+
+def _get_divisor_size(crc_divisor: str) -> int:
+    """Calculates the byte size of a CRC divisor"""
+    return int(ceil(len(crc_divisor) / 8))
+
+
+def _bytes_to_bin(msg_bytes: bytes) -> str:
+    """Converts byte array to a binary string, e.g.[6, 7] => 01100111"""
+    return ''.join(format(c, '08b') for c in msg_bytes)
+
+
+def encode(content: str, crc_divisor: str,
+           creation_time: datetime) -> Tuple[int, bytearray]:
+    """
+    Creates a bytearray with encoded content and its creation datetime.
+    Currently, the content is not being encrypted. It gets appended by the
+    Cyclic Redundancy Check (CRC) code. The CRC is computed over both the timestamp
+    and the content.
+
+    The need for a CRC is debatable. Its use is motivated by the problem of
+    non-synchronised concurrent access to the shared memory. In theory, the content
+    can get corrupted by simultaneous reading/writing. Hence, is the need to validate
+    the data retrieved from the shared memory. On the other hand, given the use case,
+    the possibility of concurrent access is only hypothetical. The implication of
+    reading an impaired data is insignificant and CRC cannot guarantee the validity
+    with 100% accuracy anyway.
+    """
+
+    # Prepend the content by the timestamp and convert the whole thing to a binary
+    # sequence.
+    ts_bytes = struct.pack('d', creation_time.timestamp())
+    body = ts_bytes + content.encode('utf8')
+    bin_body = _bytes_to_bin(body)
+
+    # Compute the CRC of the content right-padded with n zeros.
+    divisor_size = _get_divisor_size(crc_divisor)
+    padding = '0' * len(crc_divisor)
+    bin_cr = compute_crc(bin_body + padding, crc_divisor)
+    cr = int(bin_cr, 2)
+
+    # Put together the content bytes and the CRC bytes.
+    cont_size = len(body) + divisor_size
+    enc_content = bytearray(cont_size)
+    enc_content[:-divisor_size] = body
+    enc_content[-divisor_size:] = cr.to_bytes(divisor_size, byteorder='big',
+                                              signed=False)
+    return cont_size, enc_content
+
+
+def decode(enc_content: bytearray, crc_divisor: str) -> Tuple[bool, datetime, str]:
+    """
+    Decodes and validates a content encoded in a bytearray.
+    Returns the validity flag, the datetime of the content creation and the textual
+    content. If the CRC code is invalid the function returns (False, <any datetime>,
+    ''). Otherwise, it returns (True, <content creation datetime>, <textual content>).
+    """
+
+    # Compute the CRC code of the content that should include its own CRC code.
+    divisor_size = _get_divisor_size(crc_divisor)
+    bin_body = _bytes_to_bin(enc_content[:-divisor_size])
+    bin_cr = _bytes_to_bin(enc_content[-divisor_size:])[-len(crc_divisor):]
+    bin_cr = compute_crc(bin_body + bin_cr, crc_divisor)
+
+    # For a valid content the computed CRC should be zero.
+    if int(bin_cr, 2) == 0:
+        divisor_size = _get_divisor_size(crc_divisor)
+        # Decode the content creation timestamp.
+        ts = struct.unpack('d', enc_content[:8])[0]
+        # Decode the content.
+        content = enc_content[8:-divisor_size].decode('utf8')
+        return True, datetime.fromtimestamp(ts), content
+    return False, datetime.min, ''
+
+
+def _open_shared_memory(storage_name: str, max_size: int,
+                        must_exist: bool) -> Optional[SharedMemory]:
+    """
+    Creates and returns a shared memory accessor object. If must_exist == False creates
+    the shared memory block if it doesn't exist. Otherwise, if the block doesn't exist
+    returns None.
+    """
+
+    try:
+        return SharedMemory(name=storage_name, create=False, size=max_size)
+    except FileNotFoundError:
+        if must_exist:
+            return None
+        return SharedMemory(name=storage_name, create=True, size=max_size)
+
+
+def write_to_sm(content: str, creation_time: Optional[datetime] = None,
+                crc_divisor: str = DEFAULT_CRC_DIVISOR,
+                max_size: int = DEFAULT_MAX_SIZE,
+                storage_name: str = DEFAULT_STORAGE_NAME) -> bool:
+    """
+    Saves a content and its creation time in a shared memory.
+
+    The named shared memory block may or may not be already allocated. The function
+    creates or opens the block, writes the encoded content and closes the block.
+    Currently, there are no provisions for the destruction of the block.
+
+    The content gets prepended by its length in bytes, so that a reading function knows
+    how many bytes to read.
+
+    If the total length of the content doesn't fit into the maximum size of the shared
+    memory block the function does nothing and returns False. Otherwise, if the content
+    is successfully stored into the shared memory, it returns True.
+
+    Parameters:
+    content       - The content string to be stored into the stored to the
+                    shared memory.
+    creation_time - Time when the content was created, which will also be stored to the
+                    shared memory.
+                    If not provided the current time will be used.
+    crc_divisor   - A binary string used for computing the CRC.
+    max_size      - Maximum size of the shared memory block in bytes.
+    storage_name  - Name of the shared memory block.
+    """
+
+    # Encode the content and check if it fits into the shared memory block
+    creation_time = creation_time or datetime.now()
+    cont_size, enc_content = encode(content, crc_divisor, creation_time)
+    size_size = _get_byte_size(max_size)
+    total_size = cont_size + size_size
+    if total_size > max_size:
+        return False
+
+    # Open or create the named shared memory block.
+    pwd_memory = _open_shared_memory(storage_name, max_size, False)
+    if pwd_memory is None:
+        return False
+    try:
+        # Write the content size followed by the content itself.
+        pwd_memory.buf[:size_size] = cont_size.to_bytes(size_size, byteorder='big',
+                                                        signed=False)
+        pwd_memory.buf[size_size:total_size] = enc_content
+    finally:
+        pwd_memory.close()
+    return True
+
+
+def read_from_sm(crc_divisor: str = DEFAULT_CRC_DIVISOR,
+                 max_size: int = DEFAULT_MAX_SIZE,
+                 storage_name: str = DEFAULT_STORAGE_NAME) -> Tuple[bool, datetime, str]:
+    """
+    Reads from the shared memory a content and the time when it was created .
+
+    The shared memory block must already exist and hold a valid content. Like its
+    writing counterpart, this function opens and closes the shared memory block, but
+    doesn't destroy it afterward.
+
+    The content must be prepended by its length, so that the function knows how many
+    bytes to read.
+
+    The function returns (True, <content creation datetime>, <textual content>) if a
+    valid content has been successfully retrieved from the shared memory. If the content
+    is empty or too big (if the size is to be believed), or it has been deemed invalid
+    the function returns (False, <any datetime>, '').
+
+    Parameters:
+    crc_divisor   - A binary string used for computing the CRC.
+    max_size      - Maximum size of the shared memory block in bytes.
+    storage_name  - Name of the shared memory block.
+    """
+
+    size_size = _get_byte_size(max_size)
+
+    pwd_memory = _open_shared_memory(storage_name, max_size, True)
+    if pwd_memory is None:
+        return False, datetime.min, ''
+    try:
+        cont_size = int.from_bytes(pwd_memory.buf[:size_size], byteorder='big')
+        total_size = cont_size + size_size
+        # Check if the size makes sense
+        if cont_size == 0 or total_size > max_size:
+            return False, datetime.min, ''
+        # Reade and decode the content.
+        enc_content = bytearray(pwd_memory.buf[size_size:total_size])
+        return decode(enc_content, crc_divisor)
+    finally:
+        pwd_memory.close()
+
+
+def clear_sm(max_size: int = DEFAULT_MAX_SIZE, storage_name: str = DEFAULT_STORAGE_NAME,
+             delete_storage: bool = False) -> None:
+    """
+    Invalidates the content stored in shared memory by setting its length to zero and
+    optionally destroys the shared memory block. The latter may not take an immediate
+    effect though.
+
+    Parameters:
+    max_size       - Maximum size of the shared memory block in bytes.
+    storage_name   - Name of the shared memory block.
+    delete_storage - If True will destroy the shared memory block.
+    """
+
+    pwd_memory = _open_shared_memory(storage_name, max_size, True)
+    if pwd_memory is not None:
+        try:
+            size_size = _get_byte_size(max_size)
+            if size_size <= max_size:
+                cont_size = 0
+                pwd_memory.buf[:size_size] = cont_size.to_bytes(
+                    size_size, byteorder='big', signed=False)
+            if delete_storage:
+                pwd_memory.unlink()
+        finally:
+            pwd_memory.close()

test/unit/test_shared_memory_vault.py

@@ -0,0 +1,110 @@
+from datetime import datetime
+from unittest import mock
+from exasol.shared_memory_vault import (compute_crc, encode, decode, write_to_sm,
+                                        read_from_sm, clear_sm)
+
+
+def test_compute_crc():
+    assert compute_crc('11010011101100000', '011') == '100'
+
+
+def test_encode_decode():
+
+    dt = datetime(year=2023, month=12, day=11, hour=16, minute=35, second=21)
+    content = 'Supercalifragilisticexpialidocious'
+    divisor = '10011010'
+    success, enc_content = encode(content, divisor, dt)
+    assert success
+    success, dt_out, content_out = decode(enc_content, divisor)
+    assert success
+    assert dt_out == dt
+    assert content_out == content
+
+
+def test_encode_corrupt_decode():
+
+    content = 'Go ahead, make my day.'
+    divisor = '10011010'
+    _, enc_content = encode(content, divisor, datetime.now())
+    enc_content[0] ^= 127
+    success, _, _ = decode(enc_content, divisor)
+    assert not success
+
+
+@mock.patch("exasol.shared_memory_vault._open_shared_memory")
+def test_write_read(mock_sm_factory):
+
+    max_size = 200
+    mock_sm = mock.MagicMock()
+    mock_sm.buf = bytearray(max_size)
+    mock_sm_factory.return_value = mock_sm
+    divisor = '100110100011'
+    content = 'The truth will set you free.'
+    dt = datetime(year=2023, month=12, day=12, hour=8, minute=39, second=45)
+    success = write_to_sm(content, creation_time=dt, crc_divisor=divisor,
+                          max_size=max_size)
+    assert success
+    success, dt_out, content_out = read_from_sm(crc_divisor=divisor, max_size=max_size)
+    assert success
+    assert dt_out == dt
+    assert content_out == content
+
+
+@mock.patch("exasol.shared_memory_vault._open_shared_memory")
+def test_write_corrupt_read(mock_sm_factory):
+
+    max_size = 200
+    mock_sm = mock.MagicMock()
+    mock_sm.buf = bytearray(max_size)
+    mock_sm_factory.return_value = mock_sm
+    divisor = '100110100011'
+    content = 'The truth will set you free.'
+    dt = datetime(year=2023, month=12, day=12, hour=8, minute=39, second=45)
+    write_to_sm(content, creation_time=dt, crc_divisor=divisor, max_size=max_size)
+    mock_sm.buf = bytearray(max_size)
+    mock_sm.buf[10] = mock_sm.buf[10]
+    success, _, _ = read_from_sm(crc_divisor=divisor, max_size=max_size)
+    assert not success
+
+
+@mock.patch("exasol.shared_memory_vault._open_shared_memory")
+def test_read_fail_no_sm(mock_sm_factory):
+
+    # Simulate the case when the shared memory block doesn't exist.
+    mock_sm_factory.return_value = None
+    max_size = 200
+    divisor = '100110100011'
+    success, _, _ = read_from_sm(crc_divisor=divisor, max_size=max_size)
+    assert not success
+
+
+@mock.patch("exasol.shared_memory_vault._open_shared_memory")
+def test_write_fail_insufficient_memory(mock_sm_factory):
+
+    max_size = 50
+    mock_sm = mock.MagicMock()
+    mock_sm.buf = bytearray(max_size)
+    mock_sm_factory.return_value = mock_sm
+    divisor = '100110100011'
+    content = 'If you want something said, ask a man; ' \
+              'if you want something done, ask a woman.'
+    dt = datetime(year=2023, month=12, day=12, hour=9, minute=19, second=10)
+    success = write_to_sm(content, creation_time=dt, crc_divisor=divisor,
+                          max_size=max_size)
+    assert not success
+
+
+@mock.patch("exasol.shared_memory_vault._open_shared_memory")
+def test_write_clear_read(mock_sm_factory):
+
+    max_size = 200
+    mock_sm = mock.MagicMock()
+    mock_sm.buf = bytearray(max_size)
+    mock_sm_factory.return_value = mock_sm
+    divisor = '100110100011'
+    content = 'The truth will set you free.'
+    dt = datetime(year=2023, month=12, day=12, hour=8, minute=39, second=45)
+    write_to_sm(content, creation_time=dt, crc_divisor=divisor, max_size=max_size)
+    clear_sm(max_size=max_size)
+    success, _, _ = read_from_sm(crc_divisor=divisor, max_size=max_size)
+    assert not success