#105 Added storage_backend configuration element #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
reviewed
May 28, 2024
| @@ -154,7 +83,8 @@ def get_udf_bucket_path(conf: Secrets) -> str: | |||
| Builds the path of the BucketFS bucket specified in the configuration, | |||
| as it's seen in the udf's file system. | |||
| """ | |||
| return f"/buckets/{conf.get(CKey.bfs_service)}/{conf.get(CKey.bfs_bucket)}" | |||
| bucket = open_bucketfs_connection(conf) | |||
| return bucket.udf_path | |||
There was a problem hiding this comment.
Wouldn't the return type "Pathlike" would fit better for this function, instead of 'str'?
Sorry if this question is not related to the changes in the PR.
There was a problem hiding this comment.
Maybe, but then I would break compatibility and will have to change few notebooks in the AI-Lab.
tomuben
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #105
closes #106