#103 Enabled SaaS connections #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
requested changes
May 23, 2024
Comment on lines
+118
to
+119
| [CKey.saas_url, CKey.saas_token, CKey.saas_account_id], | ||
| [CKey.saas_database_id, CKey.saas_database_name] |
There was a problem hiding this comment.
How about adding an explicit signal to the values?
E.g.
{"all": [CKey.saas_url, CKey.saas_token, CKey.saas_account_id]},
{"any": [CKey.saas_database_id, CKey.saas_database_name]},
In this example I used dicts, but it could also be simple lists with the first element being a simple string with the semantics to trigger the bool-func.
There was a problem hiding this comment.
I think it will complicate both the data structure and the explanation of what it should be. It is already more generic than it is practically needed. Currently, I've got at most one group of options. I'd rather leave it as it is.
There was a problem hiding this comment.
👍
already more generic than it is practically needed
probably, yes 🙂
Applying suggestions from the review Co-authored-by: Christoph Kuhnke <[email protected]>
ckunki
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #103