Fixed mypy for Python 3.10

exasol · Oct 21, 2024 · 90df9a0 · 90df9a0
1 parent 1fb1219
commit 90df9a0
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/exasol/nb_connector/itde_manager.py b/exasol/nb_connector/itde_manager.py
@@ -209,13 +209,13 @@ def restart_itde(conf: Secrets) -> None:
     if status is ItdeContainerStatus.ABSENT:
         raise RuntimeError("The Docker-DB container doesn't exist.")
 
-    if ItdeContainerStatus.RUNNING not in status:
+    if ItdeContainerStatus.RUNNING not in status: # type: ignore[operator]
         container_name = conf.get(AILabConfig.itde_container)
         with ContextDockerClient() as docker_client:
             container = docker_client.containers.get(container_name)
             container.start()
 
-    if ItdeContainerStatus.VISIBLE not in status:
+    if not ItdeContainerStatus.VISIBLE not in status: # type: ignore[operator]
         network_name = conf.get(AILabConfig.itde_network)
         if network_name:
             _add_current_container_to_db_network(network_name)
@@ -272,3 +272,4 @@ def remove_container(conf):
     if container_name:
         remove_docker_container([container_name])
         conf.remove(AILabConfig.itde_container)
+
diff --git a/test/unit/test_itde_manager.py b/test/unit/test_itde_manager.py
@@ -21,6 +21,7 @@
     NAME_SERVER_ADDRESS,
     bring_itde_up,
     take_itde_down,
+    ItdeContainerStatus,
 )
 
 TEST_CONTAINER_NAME = "the_new_container"
@@ -106,3 +107,37 @@ def test_take_itde_down(mock_util1, mock_util2, mock_util3, secrets):
     assert secrets.get(CKey.bfs_user) is None
     assert secrets.get(CKey.bfs_password) is None
     assert secrets.get(CKey.bfs_port) is None
+
+
+@pytest.mark.parametrize("status", [
+    ItdeContainerStatus.RUNNING,
+    ItdeContainerStatus.READY,
+])
+def test_status_running(status):
+    assert ItdeContainerStatus.RUNNING in status
+
+
+@pytest.mark.parametrize("status", [
+    ItdeContainerStatus.ABSENT,
+    ItdeContainerStatus.STOPPED,
+    ItdeContainerStatus.VISIBLE,
+])
+def test_status_not_running(status):
+    assert ItdeContainerStatus.RUNNING not in status
+
+
+@pytest.mark.parametrize("status", [
+    ItdeContainerStatus.VISIBLE,
+    ItdeContainerStatus.READY,
+])
+def test_status_visible(status):
+    assert ItdeContainerStatus.VISIBLE in status
+
+
+@pytest.mark.parametrize("status", [
+    ItdeContainerStatus.ABSENT,
+    ItdeContainerStatus.STOPPED,
+    ItdeContainerStatus.RUNNING,
+])
+def test_status_not_visible(status):
+    assert ItdeContainerStatus.VISIBLE not in status