Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#425: fixed type errors found by mypy #426

Merged
merged 60 commits into from
Nov 25, 2024
Merged

#425: fixed type errors found by mypy #426

Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
505c9f2
#425: Fixed type errors found by MyPy
tomuben Nov 19, 2024
cc1bd69
Activated CI type checks
tomuben Nov 19, 2024
072f394
Updared changelog
tomuben Nov 19, 2024
c807369
Fixed build_config.py
tomuben Nov 19, 2024
e44b134
Fixed spawn_test_container.py
tomuben Nov 19, 2024
ec7117e
Fixed type error for protocol class
tomuben Nov 20, 2024
73cc903
Fixed imports
tomuben Nov 20, 2024
b928e9e
Fixed import
tomuben Nov 20, 2024
2a397a3
[run all tests]
tomuben Nov 20, 2024
97e8340
Fixed docker_image_analyze_task.py
tomuben Nov 20, 2024
a33a9ad
[run all tests]
tomuben Nov 20, 2024
576ce4e
Changed order in common.py
tomuben Nov 20, 2024
7a05968
[run all tests]
tomuben Nov 20, 2024
28e994c
Fixed conversion of ints in shell_variables.py
tomuben Nov 20, 2024
2ce0296
[run all tests]
tomuben Nov 20, 2024
d7f85e0
Fixed import in test_doctor.py
tomuben Nov 20, 2024
55f3d6f
[run all tests]
tomuben Nov 20, 2024
7ff8ffd
Added type hints to luigi config classes
tomuben Nov 20, 2024
6090b92
[run all tests]
tomuben Nov 20, 2024
f2b18e7
Integrated suggestsions from review
tomuben Nov 20, 2024
7bc8cc3
[run all tests]
tomuben Nov 20, 2024
ff0f0d2
Fixes from review
tomuben Nov 20, 2024
c9761fe
[run all tests]
tomuben Nov 20, 2024
e76c3ac
Fixes from review
tomuben Nov 20, 2024
79e533e
[run all tests]
tomuben Nov 20, 2024
c735fd4
[run all tests]
tomuben Nov 21, 2024
40697ae
Fixed AbstractSpawnTestEnvironment._default_bridge_ip_address()
tomuben Nov 21, 2024
bf0aa0b
[run all tests]
tomuben Nov 21, 2024
4a3e4fd
Fixed Generator return types
tomuben Nov 21, 2024
e8a4e81
Fixes from review findings
tomuben Nov 21, 2024
989ea22
Fixed return types in abstract_spawn_test_environment.py
tomuben Nov 21, 2024
fcd71bb
Fixed types in test_container_parameter.py
tomuben Nov 21, 2024
82af67b
Removed type ignore in test_api_logging.py
tomuben Nov 21, 2024
9b500ed
Changed type hints for ssh access
tomuben Nov 21, 2024
99064ab
Fixed wrong parameter in exaslct_test_environment.py
tomuben Nov 21, 2024
40c8980
Removed unecessary type ignore in spawn_test_container.py
tomuben Nov 21, 2024
e5f57f8
1. Fixed return type in spawn_test_database.py
tomuben Nov 21, 2024
fc52074
[run all tests]
tomuben Nov 21, 2024
2724a72
Fixed missing import in spawn_test_database.py
tomuben Nov 21, 2024
cba4a36
[run all tests]
tomuben Nov 21, 2024
19e16ad
Fixed type hint which was incompatible with Python3.9
tomuben Nov 21, 2024
a1b081f
[run all tests]
tomuben Nov 21, 2024
659ee73
Fixed type hint which was incompatible with Python3.9
tomuben Nov 21, 2024
02bbb59
[run all tests]
tomuben Nov 21, 2024
5342429
Fixed missing import in spawn_test_database.py
tomuben Nov 21, 2024
b064b96
[run all tests]
tomuben Nov 21, 2024
e25dce2
Use Union for type in spawn_test_container.py as it was incompatible …
tomuben Nov 21, 2024
e864f88
[run all tests]
tomuben Nov 21, 2024
8481cb4
Removed assertion which broke test: test_test_env_reuse.TestContainer…
tomuben Nov 21, 2024
95cdb49
[run all tests]
tomuben Nov 21, 2024
40604ab
Fixed variable name in AbstractSpawnTestEnvironment._create_ssl_certi…
tomuben Nov 22, 2024
ee5cf20
Fixed return type in CreateSSLCertificatesTask.build_image()
tomuben Nov 22, 2024
0049e3d
Fixed return type in conftest.py
tomuben Nov 22, 2024
c36d74d
Fixed types for str.join()
tomuben Nov 22, 2024
f1a37e8
Fixed types in run_minimal_tests in noxfile.py
tomuben Nov 22, 2024
5314cad
Added comment in test_populate_data.py for type ignore
tomuben Nov 22, 2024
35946b2
[run all tests]
tomuben Nov 22, 2024
c6a9beb
Added a comment in common.py
tomuben Nov 25, 2024
faca385
Fixed type hints in test_doctor.py
tomuben Nov 25, 2024
b62912a
[run all tests]
tomuben Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions exasol_integration_test_docker_environment/lib/test_environment/spawn_test_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,7 @@ def _create_database_info(self, db_ip_address: str, reused: bool) -> DatabaseInf
network_info=self.network_info,
volume_name=self._get_db_volume_name(),
)
assert self.ssh_key_file
ssh_info = SshInfo(self.ssh_user, str(self.ssh_key_file))
ssh_info = SshInfo(self.ssh_user, str(self.ssh_key_file or ""))
tkilias marked this conversation as resolved.
Show resolved Hide resolved
database_info = DatabaseInfo(
host=db_ip_address,
ports=self.internal_ports,
Expand Down