#184: Upgrade dependencies #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
commented
Nov 20, 2024
| - goerr113 # Using static errors is not necessary (https://github.com/Djarvur/go-err113) | ||
| - err113 # Using static errors is not necessary (https://github.com/Djarvur/go-err113) |
There was a problem hiding this comment.
Note: upgrade of linter required changes in this config file and added new warnings. I fixed them all.
| func (c exasolSqlClient) extractResult(rows *sql.Rows) (*QueryResult, error) { | ||
| func (c *exasolSqlClient) extractResult(rows *sql.Rows) (*QueryResult, error) { |
There was a problem hiding this comment.
Linter finding: consistently use pointer receiver.
| @@ -88,6 +88,7 @@ func (f ScriptFixture) GetMetaDataSchemaName() string { | |||
| } | |||
|
|
|||
| func (f ScriptFixture) Cleanup(t *testing.T) { | |||
| t.Helper() | |||
There was a problem hiding this comment.
Linter finding: call this method first in all helper methods.
kaklakariada
commented
Nov 20, 2024
| suite.Equal(&backend.QueryResult{Columns: []backend.Column{{Name: "COL", TypeName: "DECIMAL"}}, Rows: []backend.Row{{(float64(1))}}}, result) | ||
| suite.Equal(&backend.QueryResult{Columns: []backend.Column{{Name: "COL", TypeName: "DECIMAL"}}, Rows: []backend.Row{{(int64(1))}}}, result) |
There was a problem hiding this comment.
Seems to be caused by updated JSON in WebSocket protocol of Exasol 8.32.0
| <junit.version>5.10.2</junit.version> | ||
| <java.version>11</java.version> |
There was a problem hiding this comment.
Explicitly set Java version after upgrading PK
ckunki
previously approved these changes
Nov 20, 2024
ckunki
approved these changes
Nov 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184