Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#333: Added project short tag in notebook tests #334

Merged
merged 16 commits into from
Oct 24, 2024
Merged

#333: Added project short tag in notebook tests #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
71c88f8
#333: Added project short tag in notebook tests
ckunki Oct 7, 2024
1c6f425
Update ca-certificates version
ckunki Oct 7, 2024
df1d1aa
Fixed dependency desclaration to ca-certificates
ckunki Oct 7, 2024
7d96c9b
Fixed dependency desclaration to ca-certificates 2
ckunki Oct 7, 2024
4a045da
Fixed dependency desclaration to ca-certificates 3
ckunki Oct 7, 2024
a379de4
Fixed dependency desclaration to ca-certificates 4
ckunki Oct 7, 2024
285e584
Fixed instructions on how to update packages in developer guide
ckunki Oct 8, 2024
3bb9e32
pinned ITDE version to 3.10
ckunki Oct 15, 2024
d533eb0
Added check to validate DNS nameservers
ckunki Oct 17, 2024
4b85296
Added name server 208.67.222.222
ckunki Oct 17, 2024
e2321bf
Limited ping attempts to 3
ckunki Oct 17, 2024
308c756
Ignore failures in ping and nslookup
ckunki Oct 17, 2024
fab824c
Updated validation of DNS nameservers
ckunki Oct 17, 2024
513b65d
Merge branch 'main' into refactoring/#333-Added_project_short_tag_in_…
ckunki Oct 23, 2024
f072fa6
Cleanup
ckunki Oct 23, 2024
3fd1779
[CodeBuild]
ckunki Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/notebook_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ jobs:
NBTEST_AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
NBTEST_AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY_SECRET }}
NBTEST_AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
PROJECT_SHORT_TAG: XAIL-NB
3 changes: 3 additions & 0 deletions doc/changes/changes_3.2.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Code name:

## Summary

## Refactorings

* #333: Added project short tag in notebook tests

## Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion doc/developer_guide/updating_packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If the update is very new and not yet displayed on packages.ubuntu.com you can u

```shell
apt-get update
apt-search <package>
apt search <package>
```

Maybe installing the command [chdist](https://manpages.ubuntu.com/manpages/xenial/en/man1/chdist.1.html) could also be helpful, as it allows searching for packages and updates in other versions and distributions of ubuntu than the one installed on your local system.
4 changes: 3 additions & 1 deletion test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file, notebook
environ = os.environ.copy()
environ["NBTEST_ACTIVE"] = "TRUE"
nbtest_environ = {key: value for key, value in environ.items() if (
key.startswith("NBTEST_") or key.startswith("SAAS_"))}
key.startswith("NBTEST_")
or key.startswith("SAAS_")
or key == "PROJECT_SHORT_TAG")}
exec_command(
command_run_test,
container,
Expand Down