Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to improve type inference in ExaTron. The signature of
ExaTronProblem
has been updated, frommutable struct ExaTronProblem{VI, VD}
to
This allows Julia to infer directly the type of the matrix we are using, instead of dealing with unspecified
AbstractTronMatrix
.Also:
:ICFS
by default)TronDenseMatrix
, leading to nice speed-upA benchmark (using
profiling/qptests.jl
) gives:TronSparseMatrixCSC
, we reduce the overall number of allocations (now the functiondtron
is not allocating anything, which was not the case before, because of type inference issue)TronDenseMatrix{MT}
, we get almost a 300x speed-up:Fix #10