Use KrylovPreconditioners and using KLU as CPU solver #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frapac
approved these changes
Nov 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 69.41% 68.31% -1.10%
==========================================
Files 34 30 -4
Lines 4482 4138 -344
==========================================
- Hits 3111 2827 -284
+ Misses 1371 1311 -60 ☔ View full report in Codecov by Sentry. |
amontoison
reviewed
Dec 4, 2023
test/runtests.jl
Outdated
| ROC_ARCH = (ROCBackend(), ROCArray, ROCSparseMatrixCSR) | ||
| push!(ARCHS, ROC_ARCH) | ||
| end | ||
| # if AMDGPU.has_rocm_gpu() |
There was a problem hiding this comment.
Suggested change
| # if AMDGPU.has_rocm_gpu() | |
| # if AMDGPU.functional() |
There was a problem hiding this comment.
You can do the same thing and CUDA and oneAPI.
https://jso.dev/Krylov.jl/dev/gpu/#AMD-GPUs
michel2323
force-pushed
the
ms/krylovprecond
branch
from
9e8d38f to
f55b0d0
Compare
michel2323
changed the title
michel2323
force-pushed
the
ms/krylovprecond
branch
2 times, most recently
from
13b20e1 to
68ebbf1
Compare
michel2323
force-pushed
the
ms/krylovprecond
branch
from
e4141d6 to
64b32f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.