Remove the implementation of block-GMRES #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
commented
Dec 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 68.31% 73.64% +5.33%
==========================================
Files 30 29 -1
Lines 4137 3844 -293
==========================================
+ Hits 2826 2831 +5
+ Misses 1311 1013 -298 ☔ View full report in Codecov by Sentry. |
|
ok to remove this from ExaPF. Which package should we use for block-gmres? Krylov.jl? |
|
I opened a PR yesterday in Krylov.jl: JuliaSmoothOptimizers/Krylov.jl#840 |
|
I guess we can merge this PR once Krylov 0.9.5 has been released. |
|
I rebase the branch and it should be good: JuliaRegistries/General#96711 |
amontoison
force-pushed
the
update_krylov
branch
from
872b5cb to
a52a0a6
Compare
frapac
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.