Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Tidy #59

Merged
merged 3 commits into from
Sep 20, 2024
Merged

CMake Tidy #59

merged 3 commits into from
Sep 20, 2024

Conversation

ewanwm
Copy link
Owner

@ewanwm ewanwm commented Sep 20, 2024

Clean up the cmake system a bit. Now seems to build quite a bit quicker and the pch now no longer remakes itself for every target

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
nuTens/tensors/tensor.hpp 89.47% <ø> (ø)
nuTens/utils/logging.hpp 0.00% <ø> (ø)

Copy link
Contributor

🐰 Bencher Report

Branchfeature_cmake_tidy
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Const Density Oscillations/1024/1024📈 view plot
⚠️ NO THRESHOLD
4,694,839,971.00
Const Density Oscillations/1024/1024_cv📈 view plot
⚠️ NO THRESHOLD
0.00
Const Density Oscillations/1024/1024_mean📈 view plot
⚠️ NO THRESHOLD
4,689,041,355.56
Const Density Oscillations/1024/1024_median📈 view plot
⚠️ NO THRESHOLD
4,682,821,946.50
Const Density Oscillations/1024/1024_stddev📈 view plot
⚠️ NO THRESHOLD
20,243,006.99
Vacuum Oscillations/1024/1024📈 view plot
⚠️ NO THRESHOLD
263,802,427.00
Vacuum Oscillations/1024/1024_cv📈 view plot
⚠️ NO THRESHOLD
0.06
Vacuum Oscillations/1024/1024_mean📈 view plot
⚠️ NO THRESHOLD
273,841,850.46
Vacuum Oscillations/1024/1024_median📈 view plot
⚠️ NO THRESHOLD
266,571,954.17
Vacuum Oscillations/1024/1024_stddev📈 view plot
⚠️ NO THRESHOLD
15,281,192.48
🐰 View full continuous benchmarking report in Bencher

@ewanwm ewanwm merged commit d3f6452 into main Sep 20, 2024
3 of 5 checks passed
@ewanwm ewanwm deleted the feature_cmake_tidy branch September 20, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants