Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FINALLY fix issue with nuTens not linking properly with bencher in github action.
Seems to have been related to the flag glibcxx_use_cxx11_abi which is related to backwards compatibility with c++11 involving strings (see https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html for details) , hence why linking issue was only happening with functions taking std::string as a parameter. The flag was getting set to 0 when libtorch was included, but google benchmark was getting built with it set to 1, causing linking issues. Setting the CMAKE_CXX_FLAGS variable to include the TORCH_CXX_FLAGS before oncluding benchmark fixes the issue as benchmark now gets built with the same flags as everything else.
closes #38