Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fix benchmarking ci #39

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Workflow fix benchmarking ci #39

merged 6 commits into from
Aug 7, 2024

Conversation

ewanwm
Copy link
Owner

@ewanwm ewanwm commented Aug 7, 2024

FINALLY fix issue with nuTens not linking properly with bencher in github action.

Seems to have been related to the flag glibcxx_use_cxx11_abi which is related to backwards compatibility with c++11 involving strings (see https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html for details) , hence why linking issue was only happening with functions taking std::string as a parameter. The flag was getting set to 0 when libtorch was included, but google benchmark was getting built with it set to 1, causing linking issues. Setting the CMAKE_CXX_FLAGS variable to include the TORCH_CXX_FLAGS before oncluding benchmark fixes the issue as benchmark now gets built with the same flags as everything else.

closes #38

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

🐰Bencher

ReportWed, August 7, 2024 at 14:51:44 UTC
ProjectnuTens
Branchworkflow_fix_benchmarking_CI
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
Const Density Oscillations/1024/1024➖ (view plot)7,312,747,026.00
Const Density Oscillations/1024/1024_cv➖ (view plot)0.00
Const Density Oscillations/1024/1024_mean➖ (view plot)7,301,124,000.37
Const Density Oscillations/1024/1024_median➖ (view plot)7,295,462,796.50
Const Density Oscillations/1024/1024_stddev➖ (view plot)23,867,515.88
Vacuul Oscillations/1024/1024➖ (view plot)2,821,924,020.00
Vacuul Oscillations/1024/1024_cv➖ (view plot)0.01
Vacuul Oscillations/1024/1024_mean➖ (view plot)2,818,605,703.06
Vacuul Oscillations/1024/1024_median➖ (view plot)2,815,361,064.50
Vacuul Oscillations/1024/1024_stddev➖ (view plot)18,202,653.18

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@ewanwm ewanwm merged commit 9854f79 into main Aug 7, 2024
3 checks passed
@ewanwm ewanwm deleted the workflow_fix_benchmarking_CI branch August 7, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarking doesn't work in github action
2 participants