Feature benchmarking #37

ewanwm · 2024-08-02T21:48:08Z

Add benchmarking and integrate it using actions so it gets run on every pull request to main. Currently benchmark is pretty simple and consists of just calculating osc probabilities for 1024 batches of 1024 neutrino energies in vacuum and in constant density matter.

For some reason nuTens cannot link with the benchmark library when running in Github actions. This works fine locally so I can't figure out what's going on. Leaving as is for now and will fix in future so that benchmarking can be done in CI.

…gle benchmark tool as a dependency

… requests

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index bd0a15c..43c0288 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -10 +10,3 @@ Tensor buildPMNS(const Tensor &theta12, const Tensor &theta13, const Tensor &the
-    Tensor M1, M2, M3;
+    Tensor M1;
+    Tensor M2;
+    Tensor M3;
@@ -73 +75,4 @@ static void BM_vacuumOscillations(benchmark::State &state)
-    Tensor theta23, theta13, theta12, deltaCP;
+    Tensor theta23;
+    Tensor theta13;
+    Tensor theta12;
+    Tensor deltaCP;

Have any feedback or feature suggestions? Share it here.

benchmarks/benchmarks.cpp

github-actions · 2024-08-02T21:49:46Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,99 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^

github-actions · 2024-08-02T21:49:46Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:97:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index bd0a15c..43c0288 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -10 +10,3 @@ Tensor buildPMNS(const Tensor &theta12, const Tensor &theta13, const Tensor &the
-    Tensor M1, M2, M3;
+    Tensor M1;
+    Tensor M2;
+    Tensor M3;
@@ -73 +75,4 @@ static void BM_vacuumOscillations(benchmark::State &state)
-    Tensor theta23, theta13, theta12, deltaCP;
+    Tensor theta23;
+    Tensor theta13;
+    Tensor theta12;
+    Tensor deltaCP;

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T21:52:42Z

benchmarks/benchmarks.cpp

+Tensor buildPMNS(const Tensor &theta12, const Tensor &theta13, const Tensor &theta23, const Tensor &deltaCP)
+{
+    // set up the three matrices to build the PMNS matrix
+    Tensor M1;


clang-tidy diagnostics

multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

Tensor M1;

Tensor M1;

Tensor M2;

Tensor M3;

github-actions · 2024-08-02T21:52:42Z

benchmarks/benchmarks.cpp

+    masses.ones({1, 3}, NTdtypes::kFloat).requiresGrad(false);
+    masses.setValue({0, 0}, 0.1);
+    masses.setValue({0, 1}, 0.2);
+    masses.setValue({0, 2}, 0.3);


clang-tidy diagnostics

multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

masses.setValue({0, 2}, 0.3);

Tensor theta23;

Tensor theta13;

Tensor theta12;

Tensor deltaCP;

github-actions · 2024-08-02T21:52:42Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,104 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^

github-actions · 2024-08-02T21:52:42Z

benchmarks/benchmarks.cpp

+    for (auto _ : state)
+    {
+        // This code gets timed
+        batchedOscProbs(vacuumProp, energies, state.range(0), state.range(1));


clang-tidy diagnostic

benchmarks/benchmarks.cpp:97:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T21:54:17Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,104 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^

github-actions · 2024-08-02T21:54:17Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:102:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T21:56:46Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,104 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^

github-actions · 2024-08-02T21:56:46Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:102:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

…feature_benchmarking

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 3f15833..73765b7 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T22:03:09Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-02T22:03:09Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-02T22:03:09Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-02T22:03:09Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10}); ^

codecov-commenter · 2024-08-02T22:05:53Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 3f15833..73765b7 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T22:08:49Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-02T22:08:49Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-02T22:08:49Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-02T22:08:49Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 3f15833..73765b7 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-02T22:23:41Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-02T22:23:41Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-02T22:23:41Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-02T22:23:41Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Name("Vacuum Osc")->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Name("Const Density Osc")->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T08:52:05Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T08:52:05Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T08:52:05Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T08:52:05Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T08:56:32Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T08:56:32Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T08:56:32Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T08:56:32Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T09:09:07Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T09:09:07Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T09:09:07Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T09:09:08Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T09:11:12Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T09:11:12Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T09:11:12Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T09:11:12Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T09:31:36Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T09:31:36Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T09:31:36Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T09:31:36Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T09:34:04Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T09:34:04Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T09:34:04Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T09:34:05Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T09:41:04Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T09:41:05Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T09:41:05Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T09:41:05Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index 22848af..b1c069e 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-06T19:26:31Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-06T19:26:31Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-06T19:26:31Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-06T19:26:31Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-07T09:53:35Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 4 concern(s)

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h>
         ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
            energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0);
                                                                               ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 0}, 0.1);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 1}, 0.2);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 2}, 0.3);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    std::srand(123);
               ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 0}, 0.1);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 1}, 0.2);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    masses.setValue({0, 2}, 0.3);
                            ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12);
                                                                                 ^
/home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
    deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5);
                                                                                 ^

benchmarks/benchmarks.cpp:127:39: warning: [cppcoreguidelines-init-variables]

variable 'matterSolver' is not initialized

    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
                                      ^
                                                   = 0

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const
```
BENCHMARK(BM_vacuumOscillations)->Name("Vacuul Oscillations")->Args({1 << 10, 1 << 10});
          ^
```
benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const
```
BENCHMARK(BM_constMatterOscillations)->Name("Const Density Oscillations")->Args({1 << 10, 1 << 10});
          ^
```

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

No concerns from clang-format.

Click here for the full clang-tidy patch

diff --git a/benchmarks/benchmarks.cpp b/benchmarks/benchmarks.cpp
index e866ee4..1a8fe0a 100644
--- a/benchmarks/benchmarks.cpp
+++ b/benchmarks/benchmarks.cpp
@@ -127 +127 @@ static void BM_constMatterOscillations(benchmark::State &state)
-    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
+    std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-08-07T09:53:37Z

benchmarks/benchmarks.cpp

+
+    // set up the propagator
+    Propagator matterProp(3, 100.0);
+    std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);


clang-tidy diagnostics

variable 'matterSolver' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

github-actions · 2024-08-07T09:53:37Z

benchmarks/benchmarks.cpp

@@ -0,0 +1,149 @@
+
+#include <benchmark/benchmark.h>


clang-tidy diagnostic

benchmarks/benchmarks.cpp:2:10: error: [clang-diagnostic-error]

'benchmark/benchmark.h' file not found

#include <benchmark/benchmark.h> ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:53:80: warning: 10000.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] energies.setValue({i, 0}, ((float)std::rand() / (float)RAND_MAX) * 10000.0); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:71:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:72:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:73:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:79:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:80:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:81:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:82:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:92:16: warning: 123 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] std::srand(123); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:110:29: warning: 0.1 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 0}, 0.1); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:111:29: warning: 0.2 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 1}, 0.2); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:112:29: warning: 0.3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] masses.setValue({0, 2}, 0.3); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:118:82: warning: 0.23 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta23.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.23); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:119:82: warning: 0.13 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta13.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.13); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:120:82: warning: 0.12 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] theta12.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.12); ^ /home/runner/work/nuTens/nuTens/benchmarks/benchmarks.cpp:121:82: warning: 0.5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] deltaCP.ones({1}, NTdtypes::kComplexFloat).requiresGrad(false).setValue({0}, 0.5); ^

github-actions · 2024-08-07T09:53:37Z

benchmarks/benchmarks.cpp

+}
+
+// Register the function as a benchmark
+BENCHMARK(BM_vacuumOscillations)->Name("Vacuul Oscillations")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:143:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_vacuumOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_vacuumOscillations)->Name("Vacuul Oscillations")->Args({1 << 10, 1 << 10}); ^

github-actions · 2024-08-07T09:53:37Z

benchmarks/benchmarks.cpp

+BENCHMARK(BM_vacuumOscillations)->Name("Vacuul Oscillations")->Args({1 << 10, 1 << 10});
+
+// Register the function as a benchmark
+BENCHMARK(BM_constMatterOscillations)->Name("Const Density Oscillations")->Args({1 << 10, 1 << 10});


clang-tidy diagnostic

benchmarks/benchmarks.cpp:146:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'BM_constMatterOscillations' is non-const and globally accessible, consider making it const

BENCHMARK(BM_constMatterOscillations)->Name("Const Density Oscillations")->Args({1 << 10, 1 << 10}); ^

ewanwm added 5 commits August 2, 2024 06:56

add option to build benchmarks. If it's specified then also setup goo…

5c1ebc3

…gle benchmark tool as a dependency

add a benchmark for vacuum oscillation probability calculations

ce7d30a

Create benchmarking.yaml action to do continuous benchmarking on pull…

8ba5355

… requests

Update benchmarking.yaml with slightly longer warmup

8e8c5cb

Update README.md to include benchmark info

17301a6

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

ewanwm and others added 2 commits August 2, 2024 22:51

Update benchmarking.yaml

e0f64b3

Apply suggestions from code review

ae2ada3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

Update benchmarking.yaml

cd73c9d

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

ewanwm added 4 commits August 2, 2024 17:57

add const density matter oscillation benchmark

46d207b

keep the linter happy

a3d9fe4

Update benchmarking.yaml

c3044a5

Merge branch 'feature_benchmarking' of github.com:ewanwm/nuTens into …

6c40590

…feature_benchmarking

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

Update benchmarking.yaml to actually use the right cmake option

9dd9bc5

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

Update benchmarking.yaml

c41b5ee

github-actions bot previously requested changes Aug 2, 2024

View reviewed changes

Update CMakeLists.txt to also link benchmark::benchmark_main

86e4e55

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Update benchmarking.yaml

8fbc5df

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Update benchmarking.yaml

791a9d6

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Update benchmarking.yaml

a40bfe2

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Update benchmarking.yaml to set specific compiler (gcc 11.3.0)

4fddc16

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

try 11.2.0 instead

3a1cf1b

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Update benchmarking.yaml to actually set up gcc

fcea4d0

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

Getting desperate

3af9415

github-actions bot previously requested changes Aug 6, 2024

View reviewed changes

tidy up some of the desperate fix attempts

3adf938

github-actions bot requested changes Aug 7, 2024

View reviewed changes

ewanwm merged commit a919de8 into main Aug 7, 2024
1 of 4 checks passed

ewanwm deleted the feature_benchmarking branch August 7, 2024 09:55

ewanwm mentioned this pull request Aug 7, 2024

Benchmarking doesn't work in github action #38

Closed

	std::unique_ptr<BaseMatterSolver> matterSolver = std::make_unique<ConstDensityMatterSolver>(3, 2.6);
	std::unique_ptr<BaseMatterSolver> matterSolver = 0 = std::make_unique<ConstDensityMatterSolver>(3, 2.6);

Feature benchmarking #37

Feature benchmarking #37

Conversation

ewanwm commented Aug 2, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

codecov-commenter commented Aug 2, 2024

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Aug 2, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot left a comment

Choose a reason for hiding this comment

ewanwm commented Aug 2, 2024 •

edited

Loading