Add missing commit. Only consider running pods when scaling down. fixes

#85.

api/v1alpha1/githubactionrunner_types.go

@@ -55,6 +55,7 @@ func (r GithubActionRunnerSpec) GetReconciliationPeriod() time.Duration {
 
 // GithubActionRunnerStatus defines the observed state of GithubActionRunner
 type GithubActionRunnerStatus struct {
+	// the current size of the build pool
 	CurrentSize int `json:"currentSize"`
 }
 

controllers/githubactionrunner_controller.go

@@ -123,18 +123,28 @@ func (r *GithubActionRunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result,
 				err = r.Client.Delete(context.TODO(), &pod, &client.DeleteOptions{})
 				if err == nil {
 					instance.Status.CurrentSize--
-					err = r.Status().Update(context.TODO(), instance)
 					r.Recorder.Event(instance, corev1.EventTypeNormal, "Scaling", fmt.Sprintf("Deleted pod %s/%s", pod.Namespace, pod.Name))
 				}
-				return result, err
+				break
 			}
 		}
+
+		defer r.Status().Update(context.TODO(), instance)
+		return result, err
 	}
 
 	return result, err
 }
 
 func (r *GithubActionRunnerReconciler) SetupWithManager(mgr ctrl.Manager) error {
+	// create an index for pod status since we filter on it
+	if err := mgr.GetFieldIndexer().IndexField(context.TODO(), &corev1.Pod{}, "status.phase", func(rawObj runtime.Object) []string {
+		pod := rawObj.(*corev1.Pod)
+		return []string{string(pod.Status.Phase)}
+	}); err != nil {
+		return err
+	}
+
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&garov1alpha1.GithubActionRunner{}).
 		Complete(r)