Remove code for old features that are not used anymore #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindermax
commented
Sep 15, 2024
| @@ -142,17 +142,7 @@ def expr(*args: P.args, **kw: P.kwargs) -> _Func: | |||
|
|
|||
| expr.__def_name__ = name # type: ignore[attr-defined] | |||
| expr.__def_body__ = fn # type: ignore[attr-defined] | |||
|
|
|||
| if len(types) == 1 and isinstance(types[0], str): | |||
There was a problem hiding this comment.
This if was to support edn in defines - @define("[[:foo :bar]]").
Now we only supporting actual types such as @define(String) or @define(Record[{"foo": String, "bar": Integer}])
kindermax
commented
Sep 15, 2024
| @@ -26,7 +26,7 @@ RUN pdm sync -G dev | |||
|
|
|||
| FROM base as docs | |||
|
|
|||
| RUN pdm sync -G docs | |||
| RUN pdm sync -G dev -G docs | |||
There was a problem hiding this comment.
Without dev deps sphinx will not import hiku.readers.graphql because it can not import graphql-core library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #164