Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of articles from Evmos Docs #29

Merged
merged 33 commits into from
Nov 10, 2023
Merged

Migration of articles from Evmos Docs #29

merged 33 commits into from
Nov 10, 2023

Conversation

lmedury
Copy link
Contributor

@lmedury lmedury commented Aug 4, 2023

The following updates were made in this PR:

  • Articles from Evmos Docs have been included in Academy
  • README.md file includes instructions with illustrations to contribute to the academy repository
  • Removed FAQ article in articles/beginner

@lmedury lmedury requested a review from a team as a code owner August 4, 2023 15:52
@lmedury lmedury requested review from 0xstepit and GAtom22 and removed request for a team August 4, 2023 15:52
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for splendorous-kleicha-8d3fc0 ready!

Name Link
🔨 Latest commit ff06ec8
🔍 Latest deploy log https://app.netlify.com/sites/splendorous-kleicha-8d3fc0/deploys/654e40c79a8d560008982add
😎 Deploy Preview https://deploy-preview-29--splendorous-kleicha-8d3fc0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

README.md Outdated

**4.1**: Open your favorite choice of editor

`code .`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put here this command since for example, on VSC, you should have enabled it. So, it is not general.

README.md Outdated

In markdown, you can add text, images, videos and more.

A brief intro to markdown:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could link to markdown doc here

@@ -0,0 +1,69 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ws

Copy link

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles style are not homogeneous. Please choose only one between "Title Like This One" or "Title like this one".

@0xstepit
Copy link

0xstepit commented Aug 4, 2023

@lmedury many thanks for your contribution :) would be great if you can fix Markdown Linter errors so we can have everything homogeneous.

@lmedury
Copy link
Contributor Author

lmedury commented Aug 10, 2023

@lmedury many thanks for your contribution :) would be great if you can fix Markdown Linter errors so we can have everything homogeneous.

Thank you @0xstepit for your very helpful detailed feedback. Please review my latest commit when you get a chance.

Copy link
Collaborator

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmedury !!
Please address the lint issues and the dead links

@danburck
Copy link
Contributor

@lmedury Thanks for this! Some changes are still required, as it looks like more articles were ported than expected.

Ported to many articles
Right now this PR includes articles from the Evmos Develop and Protocol sections.

Please reduce the scope of this PR to only porting over articles from the Evmos Docs Use section to the Academy beginner section. Note to keep the folder structure as given in the docs (i.e. keep Keplr, Metamask and Ledger under Connect your wallet)

This includes the following sections, see screenshot
Screenshot 2023-10-17 at 19 30 25

Button design
There is a custom Button design that has been created on the Evmos docs. Can you port that design over to the academy?

Check the example in this screenshot of the Metamask page

Screenshot 2023-10-17 at 19 35 54

@danburck danburck merged commit bd1d390 into evmos:main Nov 10, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants