Navigation perf profiling #1658
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savelichalex
commented
Jul 29, 2022
| @@ -35,7 +37,11 @@ protected List<ReactPackage> getPackages() { | |||
| // Packages that cannot be autolinked yet can be added manually here, for example: | |||
| // packages.add(new MyReactNativePackage()); | |||
|
|
|||
| return packages; | |||
| packages = PatchedReanimatedPackage.patchPackages(packages); | |||
There was a problem hiding this comment.
It might be a good idea to apply it in Surf anyway as it completely remove patched UIManager from reanimated that they use for layout animations and it has useless overhead
sertony
force-pushed
the
development
branch
3 times, most recently
from
a7c8130 to
90c9e60
Compare
sertony
force-pushed
the
development
branch
3 times, most recently
from
6c5f6ae to
5833230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.