Update database Cleaner with rails 5 and replace Fixnum with Integer #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanTC
force-pushed
the
fix/upgrade-with-rails5-ruby2.5
branch
from
fc28227 to
a8ff80d
Compare
amrrbakry
approved these changes
Sep 14, 2018
HassanTC
force-pushed
the
fix/upgrade-with-rails5-ruby2.5
branch
6 times, most recently
from
29a05ab to
a14a0d1
Compare
HassanTC
force-pushed
the
fix/upgrade-with-rails5-ruby2.5
branch
from
a14a0d1 to
54654e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixnum is now deprecated in ruby version 2.4
https://bugs.ruby-lang.org/issues/12005
database_cleaner needs to be updated with the last version so it works with rails 5 DatabaseCleaner/database_cleaner#477