fix: feemarket blackberry security update #275
Conversation
WalkthroughThe recent updates significantly enhance the application's functionality by integrating a Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AnteHandler
participant BankKeeper
participant FeeMarketCheckDecorator
Client->>AnteHandler: Send transaction
AnteHandler->>BankKeeper: Validate funds
BankKeeper-->>AnteHandler: Funds valid
AnteHandler->>FeeMarketCheckDecorator: Check fees
FeeMarketCheckDecorator-->>AnteHandler: Fees validated
AnteHandler-->>Client: Transaction processed
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (5)
- app/ante/ante.go (2 hunks)
- app/ante/ante_test.go (5 hunks)
- app/ante/suite.go (4 hunks)
- app/app.go (2 hunks)
- go.mod (6 hunks)
Additional comments not posted (25)
app/ante/ante_test.go (4)
4-4: Approved: Integration oftestify/mock.The use of
testify/mockfor mocking dependencies is appropriate and enhances the test setup.
103-104: Approved: Creation of test accounts.The use of
CreateTestAccountsenhances the realism of the test scenarios.
50-52: Verify: Consistent use of mockedSendCoinsFromAccountToModule.Ensure that all instances of
SendCoinsFromAccountToModuleare consistently mocked across test cases.Run the following script to verify the consistent use of the mocked method:
Also applies to: 64-65
Verification successful
Consistent Use of Mocked
SendCoinsFromAccountToModuleVerifiedThe
SendCoinsFromAccountToModulemethod is consistently mocked across the test cases inapp/ante/ante_test.go. Both instances use the same parameters and return values. No inconsistencies were found.
app/ante/ante_test.go: Lines where the method is mocked consistently.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent mocking of `SendCoinsFromAccountToModule`. # Test: Search for the mocked method usage. Expect: Consistent mocking across test cases. rg --type go -A 3 $'suite.bankKeeper.On("SendCoinsFromAccountToModule"'Length of output: 193
Script:
#!/bin/bash # Description: Verify consistent mocking of `SendCoinsFromAccountToModule`. # Test: Search for the mocked method usage. Expect: Consistent mocking across test cases. rg --type go -A 3 $'suite.bankKeeper.On\\("SendCoinsFromAccountToModule"'Length of output: 596
110-115: Verify: Integration of additional parameters inFeeMarketCheckDecorator.Ensure that the additional parameters (
accountKeeper,bankKeeper,feeGrantKeeper) are correctly integrated and utilized in theFeeMarketCheckDecorator.Run the following script to verify the integration of additional parameters:
app/ante/suite.go (2)
49-49: Verify: Compatibility offeemarketmocks.BankKeeper.Ensure that the new mock implementation
feemarketmocks.BankKeeperis compatible with existing tests in the suite.Run the following script to verify the compatibility of the new mock implementation:
Verification successful
Verified: Compatibility of
feemarketmocks.BankKeeper.The
feemarketmocks.BankKeeperis integrated into the test suite and is being utilized in test functions likeTestMempoolDecorator. This suggests that the new mock implementation is compatible with the existing tests.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `feemarketmocks.BankKeeper`. # Test: Search for `feemarketmocks.BankKeeper` usage. Expect: Compatibility with existing tests. rg --type go -A 5 $'feemarketmocks.BankKeeper'Length of output: 435
Script:
#!/bin/bash # Description: Search for test functions that might use `bankKeeper` in `AnteTestSuite`. # Find all test functions in the repository rg --type go -A 5 'func Test' > all_tests.txt # Search for references to `bankKeeper` within those test functions rg --type go 'bankKeeper' --files-with-matches | xargs -I {} rg --type go -A 5 'func Test' {} > bankKeeper_tests.txt # Output the relevant test functions cat bankKeeper_tests.txtLength of output: 590
69-69: Verify: Correct instantiation offeemarketmocks.NewBankKeeper.Ensure that
feemarketmocks.NewBankKeeper(t)is correctly instantiated and aligns with the new testing context.Run the following script to verify the correctness of the new instantiation:
app/ante/ante.go (2)
35-35: Verify: Utilization ofBankKeeperinHandlerOptions.Ensure that the new
BankKeeperfield inHandlerOptionsis correctly utilized in theNewAnteHandlerconstructor.Run the following script to verify the utilization of the new field:
Verification successful
Verified: Correct utilization of
BankKeeperinHandlerOptions.The
BankKeeperfield is properly utilized in theNewAnteHandlerconstructor. It is checked for nil and used in several decorators, confirming its essential role in the handler's functionality.
NewAnteHandlerconstructor checks forBankKeeperbeing nil and returns an error if so.BankKeeperis passed toNewDeductFeeDecoratorand other decorators.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify utilization of `BankKeeper` in `HandlerOptions`. # Test: Search for `BankKeeper` usage in `NewAnteHandler`. Expect: Correct utilization. rg --type go -A 5 $'BankKeeper'Length of output: 12596
67-68: Verify: Integration ofoptions.BankKeeperinNewAnteHandler.Ensure that
options.BankKeeperis correctly integrated and utilized in theNewAnteHandlerfunction.Run the following script to verify the integration of
options.BankKeeper:Verification successful
Integration of
options.BankKeeperis verified inNewAnteHandler.The
options.BankKeeperis properly integrated and utilized within theNewAnteHandlerfunction, particularly in theNewDeductFeeDecoratorand other related decorators, ensuring its role in bank-related operations is correctly implemented.
app/ante/ante.go: Usage inNewDeductFeeDecoratorand other decorators confirms correct integration.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of `options.BankKeeper` in `NewAnteHandler`. # Test: Search for `options.BankKeeper` usage. Expect: Correct integration. rg --type go -A 5 $'options.BankKeeper'Length of output: 1963
go.mod (15)
3-3: Approved: Go version update.The update from
1.22.3to1.22.6is approved, reflecting an effort to keep the module up to date.
5-5: Approved: Toolchain version update.The update from
go1.22.4togo1.23.0is approved, reflecting an effort to keep the module up to date.
13-13: Verify: Compatibility ofgithub.com/cosmos/gogoprotov1.6.0.Ensure that the updated version
v1.6.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
31-31: Verify: Compatibility ofgoogle.golang.org/grpcv1.65.0.Ensure that the updated version
v1.65.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
209-209: Verify: Compatibility ofgolang.org/x/termv0.23.0.Ensure that the updated version
v0.23.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
Verification successful
No direct usage of
golang.org/x/termfound in the codebase.The search did not reveal any direct usage of
golang.org/x/term, suggesting that the update tov0.23.0should not cause compatibility issues. If the dependency is used indirectly, ensure that the dependent packages are compatible with the updated version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `golang.org/x/term` v0.23.0. # Test: Search for `term` usage. Expect: Compatibility with the updated version. rg --type go -A 5 $'term'Length of output: 1834
207-207: Verify: Compatibility ofgolang.org/x/syncv0.8.0.Ensure that the updated version
v0.8.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
Verification successful
Verified: Compatibility of
golang.org/x/syncv0.8.0.The update to
golang.org/x/syncv0.8.0 does not affect the usage of thesyncpackage in the codebase, specificallysync.Once, which is part of the standard library. The code is compatible with the updated version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `golang.org/x/sync` v0.8.0. # Test: Search for `sync` usage. Expect: Compatibility with the updated version. rg --type go -A 5 $'sync'Length of output: 476
57-57: Verify: Compatibility ofgithub.com/skip-mev/feemarketv1.1.0.Ensure that the updated version
v1.1.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
214-214: Verify: Compatibility ofgoogle.golang.org/genproto/googleapis/rpcv0.0.0-20240709173604-40e1e62336c5.Ensure that the updated version is compatible with the codebase.
Run the following script to verify the compatibility of the updated version:
Verification successful
Verified: Indirect Dependency Update for
google.golang.org/genproto/googleapis/rpc.The dependency is marked as indirect and is not directly used in the codebase. The update to version
v0.0.0-20240709173604-40e1e62336c5should not impact the codebase directly. Ensure that dependent libraries are compatible with this version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `google.golang.org/genproto/googleapis/rpc` v0.0.0-20240709173604-40e1e62336c5. # Test: Search for `genproto/googleapis/rpc` usage. Expect: Compatibility with the updated version. rg --type go -A 5 $'genproto/googleapis/rpc'Length of output: 43
Script:
#!/bin/bash # Description: List all dependencies and their versions to check for indirect usage of `genproto/googleapis/rpc`. # List all dependencies in go.mod and their versions cat go.modLength of output: 11757
38-38: Verify: Compatibility ofcosmossdk.io/corev0.11.1.Ensure that the updated version
v0.11.1is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
203-203: Verify: Compatibility ofgolang.org/x/cryptov0.26.0.Ensure that the updated version
v0.26.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
205-205: Verify: Compatibility ofgolang.org/x/netv0.28.0.Ensure that the updated version
v0.28.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
Verification successful
Compatibility of
golang.org/x/netv0.28.0 appears intact.The usage of the
netpackage incmd/eved/testnet.gois primarily for IP parsing, which is unlikely to be affected by minor version updates. However, it is recommended to manually review the release notes ofgolang.org/x/netv0.28.0 for any breaking changes that could affect the codebase.
- File:
cmd/eved/testnet.go- Function:
initTestnetFilesScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `golang.org/x/net` v0.28.0. # Test: Search for `net` usage. Expect: Compatibility with the updated version. rg --type go -A 5 $'net'Length of output: 15117
11-11: Verify: Compatibility ofgithub.com/cosmos/cosmos-sdkv0.50.9.Ensure that the updated version
v0.50.9is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
Verification successful
Compatibility Verified:
github.com/cosmos/cosmos-sdkv0.50.9The update to version
v0.50.9includes bug fixes and compatibility improvements without introducing breaking changes. It should be compatible with the existing codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `github.com/cosmos/cosmos-sdk` v0.50.9. # Test: Search for `cosmos-sdk` usage. Expect: Compatibility with the updated version. rg --type go -A 5 $'cosmos-sdk'Length of output: 17545
Script:
#!/bin/bash # Fetch the changelog or release notes for `github.com/cosmos/cosmos-sdk` v0.50.9 to check for breaking changes or important updates. curl -s https://api.github.com/repos/cosmos/cosmos-sdk/releases/tags/v0.50.9 | jq '.body'Length of output: 1077
208-208: Verify: Compatibility ofgolang.org/x/sysv0.23.0.Ensure that the updated version
v0.23.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
210-210: Verify: Compatibility ofgolang.org/x/textv0.17.0.Ensure that the updated version
v0.17.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
70-70: Verify: Compatibility ofcosmossdk.io/depinjectv1.0.0.Ensure that the updated version
v1.0.0is compatible with the codebase.Run the following script to verify the compatibility of the updated version:
app/app.go (2)
Line range hint
484-486: Verify: Impact ofFeeGrantKeeperremoval fromPostHandlerOptions.Ensure that the removal of
FeeGrantKeeperaligns with the intended functionality and does not affect fee management.Run the following script to verify the impact of the removal:
Verification successful
Verification Successful:
FeeGrantKeeperRemoval fromPostHandlerOptionsThe removal of
FeeGrantKeeperfromPostHandlerOptionsdoes not adversely affect the fee management functionality. It is still present and used elsewhere in the codebase, indicating its relevance for other modules.
FeeGrantKeeperis initialized and used inapp/app.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify impact of `FeeGrantKeeper` removal from `PostHandlerOptions`. # Test: Search for `FeeGrantKeeper` usage in `PostHandlerOptions`. Expect: No adverse impact. rg --type go -A 5 $'PostHandlerOptions'Length of output: 629
Script:
#!/bin/bash # Description: Search for any remaining usages of `FeeGrantKeeper` in the codebase to verify its removal impact. # Test: Search for `FeeGrantKeeper` usage in the codebase. Expect: No remaining critical usages. rg --type go 'FeeGrantKeeper'Length of output: 406
Line range hint
573-575: Verify: Impact ofFeeGrantKeeperremoval fromNewPostHandler.Ensure that the removal of
FeeGrantKeeperaligns with the intended functionality and does not affect fee management.Run the following script to verify the impact of the removal:
Verification successful
Removal of
FeeGrantKeeperfromNewPostHandlerdoes not impact its functionality.The
FeeGrantKeeperis not used within theNewPostHandlerfunction, so its removal does not affect the function's operation. However, it is still utilized elsewhere in the application, ensuring its continued relevance.
- The removal aligns with the intended functionality for
NewPostHandler.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify impact of `FeeGrantKeeper` removal from `NewPostHandler`. # Test: Search for `FeeGrantKeeper` usage in `NewPostHandler`. Expect: No adverse impact. rg --type go -A 5 $'NewPostHandler'Length of output: 696
Script:
#!/bin/bash # Search for any usage of `FeeGrantKeeper` in the codebase to verify its impact. rg --type go 'FeeGrantKeeper'Length of output: 406
|
thanks so much @aljo242 -- super, super appreciated! |
|
Hey @aljo242 thanks so much for this PR! Only reason I'm not merging yours is I needed to make another with a fix for a go.mod and go.sum conflict. Thanks again, Skip FTW! |
x/feemarkettov1.1.0AuthKeeperwas not being initialized properly)Summary by CodeRabbit
New Features
BankKeeperin theNewAnteHandler.Bug Fixes
Documentation
FeeGrantKeeperfrom post-handler options.Chores