-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix hm module #5
Conversation
0c916c0
to
dada7df
Compare
766a0fe
to
82f7e91
Compare
enable = true; | ||
enableBashIntegration = true; | ||
tabryFiles = [ | ||
./zellij.tabry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably figure out a better example, as zellij actually does have its own shell completion... When I do, I'll change it here
One useful example I may make (especially when I get delegation working better) is you could have your own aliases dc r
, dc e
, etc. -- one command with subcommands delegated to different commands -- and have shell completion for all the subcommands ... right now I don't actually know an easy way of doing that without tabry.
nix/tabry-hm-module.nix
Outdated
|
||
programs.bash.initExtra = lib.mkIf cfg.enableBashIntegration ( | ||
'' | ||
export TABRY_IMPORTS_PATH="${tabryFileDir}:$TABRY_IMPORTS_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be TABRY_IMPORT_PATH (variable used in the rust version -- TABRY_IMPORTS_PATH is used in the ruby version), right?
One issue I'm running into right now with the home-manager module is that during installation, the module will move the tabry files into a folder in the nix store (which is immutable), and add that to tabry will pick up those files fine, but then it tries to write a cache file in the same folder it found the I'm wondering if you think it would make sense to have the cache folder tabry uses be configurable? I can take a stab at that if you want. |
Sure you can take a shot at that, let me know if you have any rust questions. |
Actually, I think it'll just be easy enough to compile the json ahead of time, during installation... I didn't realize tabry will skip compiling if it already has a |
06d3626
to
a7b8e3a
Compare
Ok, this is in a pretty good state, now! |
nix/tabry-hm-module.nix
Outdated
|
||
programs.fish.shellInit = lib.mkIf cfg.enableFishIntegration ( | ||
'' | ||
set -x TABRY_IMPORT_PATH "${tabryImportsPath}:$TABRY_IMPORTS_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second one on this line should also be $TABRY_IMPORT_PATH, right? (And in the bash.initExtra below, and the comment above)
a7b8e3a
to
bcf8bc2
Compare
This commit adds a home-manager (https://github.com/nix-community/home-manager) module to tabry to make installation & configuration of tabry easier for home-manager users.