Fix Wrapper comments by BertP #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weltschmerz-dev
changed the title
|
@Bert-Proesmans Please review changes |
Bert-Proesmans
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #3
✅ Alle keyword closest matches binnen edit distance 4
✅ "No relation found for field" beschrijft niet welke actie verkeerd is en ook geen suggestie voor fix
✅ "Field '{self.field_name}' is not a relational field and has no attribute '{attr}'." klopt niet met if-statements
✅ Vreemd return type "ModelProxy" van operator functies, idealiter returning niks
✅ Collect accesses in ModelProxy is overbodig
✅ setdefault is niet lazy in tweede parameter, en introspect_fields zal altijd uitgevoerd worden, hier wordt nooit gecached
✅ xmlrpc is stateless, er is geen close of logout