Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #912

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Conversation

Exanc
Copy link

@Exanc Exanc commented Oct 26, 2020

I've been working on this French translation of Etterna, of course everything cannot be translated in Etterna and some uses of words are debatable but I think I got it pretty much right.

PS: Fixes are still needed and these will come with time.

Exanc added 7 commits October 26, 2020 13:53
The word "Chart" wasn't corectly translated, and also assumed "Assets" is a Anglicism since no french equivalent can be found.
 - New translation
 - Added comments to HightLight untraduced/unsure parts
 - Corrections (replaced "Tab" by "Onglet" and other small stuff)
@Exanc
Copy link
Author

Exanc commented Oct 28, 2020

There's still some work to do regarding the fr.ini in the _fallback theme.

 - Initial inspection of fr.ini finished
 - Marked with comments all untraduced parts
 - Added feilds that were in en.ini and not in fr.ini
 - A lot of feilds seemed to be unused inside fr.ini (especially ones concerning "courses")
 - Also corrected stuff inside fr.ini of 'Til Death
@poco0317
Copy link
Member

You are right that a lot of things in fallback are kind of just unused. Some of it is left there for possible future usability, but most of it is leftover from removing a large number of game or theme features. There needs to be an audit of some kind on the fallback language files.

@Exanc
Copy link
Author

Exanc commented Oct 28, 2020

Now that i've compared en.ini and fr.ini I realy don't whant to do it anymore it took 10 hours to compare every feilds, so unused feilds are going to wait to be remouved. Maybe one day.

Exanc added 3 commits October 28, 2020 22:54
its going to be long
 - Traduced new feilds in fr.ini
 - Finished sorting feilds of [OptionTitles] in fr.ini like they are in en.ini
 - The 2 new files are temporary files just to isolate these two parts
 - As expected feilds concerning "courses" are unused, might do a purge one time
@Exanc Exanc marked this pull request as draft October 29, 2020 20:49
@Exanc
Copy link
Author

Exanc commented Nov 3, 2020

If some of you guys have french freinds or you speak french I would really like to have some feedback on my work so far. Also if someone could help me with the conflicts that have arose, I have a very hard time trying to fix then but GitHub is constatly saying that conflicts markers are still there.

@poco0317
Copy link
Member

poco0317 commented Nov 3, 2020

The merger can resolve the conflicts when the time comes.

There are issues with the font ingame when using the language that we might have to resolve a little later.

@Exanc
Copy link
Author

Exanc commented Nov 3, 2020

Yeah I was trying to figure that out too, but I still cannot fully undurstand the structure of themes.

@poco0317
Copy link
Member

poco0317 commented Nov 3, 2020

Basically fonts are a spritesheet and the associated .ini for a font maps individual characters to tiles on the sheet. Letters that just aren't in the ini and aren't in any of the fallback inis show up like that.

@Exanc
Copy link
Author

Exanc commented Nov 3, 2020

Ok

@Exanc Exanc marked this pull request as ready for review November 5, 2020 21:03
@nico-abram
Copy link
Member

Resolved conflicts. @Exanc is it ok if we merge this?

@nico-abram
Copy link
Member

Actually, I forgot about the font issues. If someone can make a list of the characters that are broken ingame I can try to create a new fallback font atlas with them

@Exanc
Copy link
Author

Exanc commented May 8, 2022

@nico-abram I hanven't gave a look at this for a long time but I think it's good for me. From what I remember there is just some things that will need to be fixed with the UI for this to be perfect (the text being too long). I'n the mean time I have participated in the osu wiki and I think I can take some principles from them to apply it here.

So for now, if you feel satisfied, you can merge this one, but some modifications may come afterwards.

@Exanc
Copy link
Author

Exanc commented May 8, 2022

oh.. yes, the fonts issues. I forgot about them too.
I'll work on this tomorrow.

@Exanc
Copy link
Author

Exanc commented May 9, 2022

Here is the full list of all latin characters (from the ASCII/ISO 8859 (Latin-1)), they all have the corresponding texture but are very small compaired to other characters.

ÀÁÂÃÄÅÆ àáâãäåæ Ç ç ÈÉÊË èéêë ÌÍÎÏ ìíîï Ðð Ñ ñ ÒÓÔÕÖ òóôõö ÙÚÛÜ ùúûü

If you're only interested in French characters: À à Ç ç Î î Ï ï Ô ô Ù ù Ü ü

@Exanc
Copy link
Author

Exanc commented May 9, 2022

It also seems that it's only the case in some parts of th UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants