Support CloudFunctionInvokeFunctionOperator #110
Conversation
| type: string | ||
| api_version: | ||
| type: string | ||
| impersonation_chain: |
There was a problem hiding this comment.
Not sure how to represent here string or array[string]. I just chose to represent it as array of strings. I guess I'll need to use anyof \ oneof, but I wasn't sure exactly how. PTAL and suggest a fix if I should change it... Thanks!
| properties: | ||
| function_id: | ||
| type: string | ||
| input_data: |
There was a problem hiding this comment.
input_data is Dict. I'm not sure if this is the right representation. PTAL.
|
|
||
| name: gcp_cloud_function_invoke | ||
| operator_class: CloudFunctionInvokeFunctionOperator | ||
| operator_class_module: airflow.providers.google.cloud.operators.functions |
There was a problem hiding this comment.
I didn't see any other examples of using airflow.providers.google.cloud.... AFAIK it should be supported, just want to make sure that I'm not missing something...
Thanks!
There was a problem hiding this comment.
Hey @peleyal , we use boundary-layer with airflow version 1.10.3. I'd like to check out this PR and make sure it has no adverse effects on our end since this operator doesn't yet exist there.
There was a problem hiding this comment.
Sure! Do you have any way to support later versions? Should we for example provide another plugin in this repo for all operators after 1.10.3?
There was a problem hiding this comment.
Thanks for adding #114 (comment). I'm just curious now, what happens if you add this operator but don't use it. Can it still break you guys?
There was a problem hiding this comment.
It probably won't break us but it will likely confuse the community and our users as well if they try to use it. I'd prefer we not add it for now.
There was a problem hiding this comment.
OK. Thanks for all you details and help!
|
@dossett can you help me pushing this PR? Thanks! |
@vchiapaikeo Can you or anyone else take a look at this one? Thank you! |
|
Mentioned earlier in the issue but please try to create this operator in your plugin - |
Adding support in CloudFunctionInvokeFunctionOperator.
This addresses the feature requested by me in #109.