[Bug] Incorrect prop type in Toolbar Menu #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojleaton
requested review from
JeffGreiner-eaton,
huayunh and
surajeaton
as code owners
github-actions
bot
added
the
brightlayer-ui
manojleaton
requested review from
KomalGDhere-eaton,
ektaghag-eaton,
ArshdeepSingh3-eaton,
komal-eaton and
shubham-eaton
|
Visit the preview URL for this PR (updated for commit 0e453ec): https://blui-react-docs--pr906-bug-6032-incorrect-p-vyl2ok0d.web.app (expires Sun, 08 Sep 2024 06:53:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #906 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 58 58
Lines 1226 1226
Branches 154 154
=======================================
Hits 1027 1027
Misses 100 100
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shubham-eaton
approved these changes
Sep 6, 2024
shubham-eaton
deleted the
bug/6032-Incorrect-prop-type-in-ToolbarMenu-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #BLUI-6032 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?