Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PREFERRED_PROTOBUF_EXECUTABLE globally #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rasaford
Copy link

@rasaford rasaford commented Mar 8, 2022

When setting USE_SYSTEM_PROTOBUF to anything other that AUTO the variable PREFERRED_PROTOC_EXECUTABLE stores the preferred protobuf version afaik. However, this variable is not exported beyond the current cmake project it was defined in. This PR fixed this behavior.

We require this to force protobuf_catkin to use the protouf version supplied by grpc, instead of the system one, since the two are not guaranteed to be the same version.

Tested on 5.13.0-30-generic #33~20.04.1-Ubuntu

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants