pectra devnet4: implement pectra devnet4 spec #3706

g11tech · 2024-09-27T09:04:23Z

refrence:

https://notes.ethereum.org/@ethpandaops/pectra-devnet-4

jochem-brouwer · 2024-09-27T09:19:01Z

Can we use this PR as devnet-4 branch and not merge this until devnet-4 is specced out completely?

Ref for further additions: ethereum/execution-spec-tests#832

Devnet-4 spec https://notes.ethereum.org/@ethpandaops/pectra-devnet-4

g11tech · 2024-09-27T10:03:42Z

yes apparently the address specified in the 7002 eip and in the genesis generator changes don't match
cc @parithosh

in EIP:

in genesis generator PR:

parithosh · 2024-09-27T10:08:42Z

ah there's probably an update missing. lemme me clear that up and get back to you!

parithosh · 2024-09-27T10:10:59Z

are you sure @g11tech ?

EIP update was merged in: https://github.com/ethereum/EIPs/pull/8890/files#diff-70472fac1debb567783ce13873323261713f3ce488a26a5c3769a9193f4a7e27R521

which is the address we used in the genesis generator: https://github.com/ethpandaops/ethereum-genesis-generator/pull/143/files#diff-e563a01282cd9e2db47dceb99a9337f1f37466f6bfe5d10b376435d51f179f34R114

g11tech · 2024-09-27T10:17:19Z

are you sure @g11tech ?

EIP update was merged in: https://github.com/ethereum/EIPs/pull/8890/files#diff-70472fac1debb567783ce13873323261713f3ce488a26a5c3769a9193f4a7e27R521

which is the address we used in the genesis generator: https://github.com/ethpandaops/ethereum-genesis-generator/pull/143/files#diff-e563a01282cd9e2db47dceb99a9337f1f37466f6bfe5d10b376435d51f179f34R114

yes i am sure as of the current published EIP :)

as well as latest github file

jochem-brouwer · 2024-09-28T01:12:57Z

I just manually checked the EIP-7002 data, I get this:

sender: 0xac6afb9d8491e8b397f65331ce41e338cbfe1048
contract address: '0x0511ce19514e1298fba96de582652a016e2caaaa'

jochem-brouwer · 2024-09-28T01:32:36Z

@parithosh I just saw that the address got updated again in this commit: ethereum/EIPs@a23be81

In this PR:
ethereum/EIPs#8855

This changed code, so it also changed the address. (I assume this is included in devnet-4?)

jochem-brouwer · 2024-09-28T01:43:13Z

packages/vm/src/params.ts

@@ -78,7 +78,7 @@ export const paramsVM: ParamsDict = {
  7002: {
    // config
    systemAddress: '0xfffffffffffffffffffffffffffffffffffffffe', // The system address to perform operations on the withdrawal requests predeploy address
-    withdrawalRequestPredeployAddress: '0x00A3ca265EBcb825B45F985A16CEFB49958cE017', // Address of the validator excess address
+    withdrawalRequestPredeployAddress: '0x05F27129610CB42103b665629CB5c8C00296AaAa', // Address of the validator excess address


This is the address of this commit: ethereum/EIPs@1335765

The latest commit (which shows up on eips.ethereum.org) is ethereum/EIPs@a23be81 pointing to 0x0511Ce19514e1298Fba96de582652A016E2CAaAa

yes @parithosh mentioned there are a few more updates coming through, so we gotta hold on

…les and spcs

jochem-brouwer · 2024-10-10T01:35:35Z

Fixed merge conflicts, if I messed up please rollback to 7cd91a2

jochem-brouwer · 2024-10-10T04:01:53Z

Have updated the PR (have not fixed tests) to reflect these EIP PRs:

ethereum/EIPs#8924
ethereum/EIPs#8934

I have also added support for the devnet-4 t8ntool interface, can be used to fill ethereum/execution-spec-tests#832 (I got a few filled tests, so the interface works, until I ran in a bug at EEST side).

jochem-brouwer · 2024-10-10T10:06:39Z

We can actually get rid of the whole DepositRequest, WithdrawalRequest, etc, since now the requests only have a type and whatever the internal bytes are have (for us) no structure other than "just" being bytes. Also see ethereum/execution-apis#591

holgerd77 · 2024-10-10T10:47:25Z

We can actually get rid of the whole DepositRequest, WithdrawalRequest, etc, since now the requests only have a type and whatever the internal bytes are have (for us) no structure other than "just" being bytes. Also see ethereum/execution-apis#591

Oh, that's a major one we should absolutely do before the releases, can you please (don't need to be long) open a dedicated issue on this so that we do not forget?

jochem-brouwer · 2024-10-10T10:57:31Z

The idea was actually to directly do that here :)

EDIT: this is also the result of the EIP revamps for the requests, I think this will naturally follow once we integrate it.

jochem-brouwer · 2024-10-10T11:52:13Z

Never mind, removing them actually does not sounds like a good idea. The classes are now handy to also directly decode the raw bytes, which is handy for the end-user.

…n for buildblock and runblock and corresponding requestsroot calcs

…x the test including fixing a logs bloom bug in the generate fields block generation

acolytec3 · 2024-10-31T19:29:50Z

packages/util/src/request.ts

-      index: bigIntToHex(this.index),
-    }
+export class DepositRequest extends CLRequest<CLRequestType.Deposit> {
+  constructor(requestData: Uint8Array) {


Is it useful to have these sub classes now since they are functionally identical? Couldn't we just have a CLRequest class and then use the type property to distinguish between them?

acolytec3 · 2024-10-31T19:30:11Z

packages/util/src/request.ts

+export function createCLRequest<T extends CLRequestType>(bytes: Uint8Array): CLRequest<T> {
+  switch (bytes[0]) {
+    case CLRequestType.Deposit:
+      return new DepositRequest(bytes.subarray(1)) as CLRequest<T>


As above. Do we really need this? Feels very duplicative.

acolytec3

Looks good from my perspective, though the CLRequest code looks needlessly duplicative to my untrained eye.

jochem-brouwer · 2024-10-31T21:31:25Z

Just merged, thanks a lot all! 😄 👍

holgerd77 · 2024-11-02T14:10:23Z

packages/block/src/index.ts

@@ -4,7 +4,7 @@ export * from './consensus/index.js'
 export { type BeaconPayloadJSON, executionPayloadFromBeaconPayload } from './from-beacon-payload.js'
 export * from './header/index.js'
 export {
-  genRequestsTrieRoot,
+  genRequestsRoot,


Should we call this genRequestsHash ?

Yep this is actually a better name since it is not a trie root anymore!

holgerd77 · 2024-11-02T14:18:54Z

🎉

vm: update the system contract addresses for prague devnet4

bcb48d2

g11tech added package: vm package: client labels Sep 27, 2024

jochem-brouwer reviewed Sep 28, 2024

View reviewed changes

g11tech and others added 4 commits September 29, 2024 14:25

change the requests root from trie root to flat root and update examp…

1c30c2a

…les and spcs

convert requests to flat type across util,block and vm

73003e7

bundle execution requests separately from execution payload

7cd91a2

Merge branch 'master' into devnet4-contracts

b4c704b

jochem-brouwer mentioned this pull request Oct 10, 2024

vm/tx: update 7702 to devnet-4 #3737

Merged

2 tasks

jochem-brouwer added 2 commits October 10, 2024 06:00

t8ntool: update to devnet-4 interface support

420a7aa

update devnet-4 to EIP PRs 8924, 8394

1b65e0c

t8ntool hotfix to fix state tests

6d39f31

g11tech added 5 commits October 11, 2024 20:38

refactor cl requests to the new simplified version

7d023c4

remove requests from the block and modify associated code paths

2998547

remove storing and retriving of requests from blockchain

5d2ede2

modify the deposit, withdrawal and consolidation requests accumulatio…

5fe681b

…n for buildblock and runblock and corresponding requestsroot calcs

modfiy the 7002 eip spec along with the new contract and debug and fi…

613c900

…x the test including fixing a logs bloom bug in the generate fields block generation

scorbajio and others added 12 commits October 28, 2024 11:59

Merge branch 'master' into devnet4-contracts

9c64353

Remove requests from being passed in as blockData

328cd53

Remove old tests that do not conform to new devnet4 specs

c7f4640

Remove old test that does not conform to new devnet4 specs

a973b43

make linter happy

000839d

block: make tsc happy

d91b666

block: remove obsolete examples

84f40e3

util: make tsc happy

d3e6cca

vm: make linter and tsc happy

802145d

blockchain: make linter happy

88eb200

vm: fix example

adff539

make cspell happy

46ec57d

acolytec3 reviewed Oct 31, 2024

View reviewed changes

acolytec3 previously approved these changes Oct 31, 2024

View reviewed changes

client/util/vm: simplify CLRequest

5446fb8

jochem-brouwer dismissed acolytec3’s stale review via 5446fb8 October 31, 2024 19:59

acolytec3 approved these changes Oct 31, 2024

View reviewed changes

Merge branch 'master' into devnet4-contracts

152ae16

jochem-brouwer merged commit b37a8d9 into master Oct 31, 2024
38 of 41 checks passed

jochem-brouwer added package: block package: blockchain package: common package: util labels Oct 31, 2024

scorbajio deleted the devnet4-contracts branch November 1, 2024 17:07

holgerd77 reviewed Nov 2, 2024

View reviewed changes

holgerd77 added PR state: needs review type: spec updates labels Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pectra devnet4: implement pectra devnet4 spec #3706

pectra devnet4: implement pectra devnet4 spec #3706

g11tech commented Sep 27, 2024 •

edited

Loading

jochem-brouwer commented Sep 27, 2024 •

edited

Loading

g11tech commented Sep 27, 2024 •

edited

Loading

parithosh commented Sep 27, 2024

parithosh commented Sep 27, 2024

g11tech commented Sep 27, 2024 •

edited

Loading

jochem-brouwer commented Sep 28, 2024

jochem-brouwer commented Sep 28, 2024

jochem-brouwer Sep 28, 2024

g11tech Sep 29, 2024

jochem-brouwer commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024

holgerd77 commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024 •

edited

Loading

jochem-brouwer commented Oct 10, 2024 •

edited

Loading

acolytec3 Oct 31, 2024

acolytec3 Oct 31, 2024

acolytec3 left a comment

jochem-brouwer commented Oct 31, 2024

holgerd77 Nov 2, 2024

jochem-brouwer Nov 2, 2024

holgerd77 commented Nov 2, 2024

pectra devnet4: implement pectra devnet4 spec #3706

pectra devnet4: implement pectra devnet4 spec #3706

Conversation

g11tech commented Sep 27, 2024 • edited Loading

jochem-brouwer commented Sep 27, 2024 • edited Loading

g11tech commented Sep 27, 2024 • edited Loading

parithosh commented Sep 27, 2024

parithosh commented Sep 27, 2024

g11tech commented Sep 27, 2024 • edited Loading

jochem-brouwer commented Sep 28, 2024

jochem-brouwer commented Sep 28, 2024

jochem-brouwer Sep 28, 2024

Choose a reason for hiding this comment

g11tech Sep 29, 2024

Choose a reason for hiding this comment

jochem-brouwer commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024

holgerd77 commented Oct 10, 2024

jochem-brouwer commented Oct 10, 2024 • edited Loading

jochem-brouwer commented Oct 10, 2024 • edited Loading

acolytec3 Oct 31, 2024

Choose a reason for hiding this comment

acolytec3 Oct 31, 2024

Choose a reason for hiding this comment

acolytec3 left a comment

Choose a reason for hiding this comment

jochem-brouwer commented Oct 31, 2024

holgerd77 Nov 2, 2024

Choose a reason for hiding this comment

jochem-brouwer Nov 2, 2024

Choose a reason for hiding this comment

holgerd77 commented Nov 2, 2024

g11tech commented Sep 27, 2024 •

edited

Loading

jochem-brouwer commented Sep 27, 2024 •

edited

Loading

g11tech commented Sep 27, 2024 •

edited

Loading

g11tech commented Sep 27, 2024 •

edited

Loading

jochem-brouwer commented Oct 10, 2024 •

edited

Loading

jochem-brouwer commented Oct 10, 2024 •

edited

Loading