Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers/logger: fix json-logger output missing #30804

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 25, 2024

Fixes a flaw introduced in #29795 , discovered while reviewing #30633 .

Merge this and rebase #30633 on top of it?

@holiman holiman added this to the 1.14.13 milestone Nov 25, 2024
@holiman holiman requested a review from s1na as a code owner November 25, 2024 07:38
@holiman holiman changed the title eth/tracers/logger: fix flaw hiding scope output, introduced in #29795 eth/tracers/logger: fix json-logger output missing Nov 25, 2024
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@holiman holiman merged commit ab4a1cc into ethereum:master Nov 25, 2024
2 of 3 checks passed
@holiman holiman deleted the fix_jsonlogger branch November 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants