Make the switch to docc
#833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
force-pushed
the
docc
branch
4 times, most recently
from
611357b
to
2c9d1af
Compare
petertdavies
approved these changes
Oct 13, 2023
Update doc build to use docc
Update pyproject.toml
Update gh-pages.yaml
Start a docc plugin for diffs
Fix build inside of tox
Get diff working
Use ins/del instead of div
Reduce irrelevant diffs in name nodes
Pass through parent instead of creating div
Support markdown diff
pull in latest fladrif
Group diffs where possible
Show diffs in directory listings
Exclude ethereum_{optimized,spec_tools}
Switch to published docc
For some reason, pypy (and cpython on GitHub) cannot seem to correctly patch the london hardfork using the `patch` function. I've switched to using the `patch.object` function since you can explicitly provide the object, bypassing the import error. I'm not 100% sure this is correct.
SamWilsn
commented
Nov 7, 2023
Comment on lines
+105
to
+110
| fork_module = importlib.import_module( | ||
| f"ethereum.{load.fork_module}.fork" | ||
| ) | ||
| with patch.object( | ||
| fork_module, | ||
| "validate_proof_of_work", |
There was a problem hiding this comment.
@gurukamath @petertdavies if you could double check that this change maintains the original behaviour, I'd appreciate it!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 74.10% 74.11% +0.01%
==========================================
Files 572 572
Lines 32028 32411 +383
==========================================
+ Hits 23733 24022 +289
- Misses 8295 8389 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SamWilsn
force-pushed
the
docc
branch
3 times, most recently
from
b13c22b
to
ffd6e1f
Compare
SamWilsn
force-pushed
the
docc
branch
4 times, most recently
from
ec0cc75
to
3de7833
Compare
gurukamath
reviewed
Mar 18, 2024
Comment on lines
+88
to
+96
| if isinstance(pkg.module_finder, importlib.abc.MetaPathFinder): | ||
| found = pkg.module_finder.find_module(pkg.name, None) | ||
| else: | ||
| found = pkg.module_finder.find_module(pkg.name) | ||
|
|
||
| if not found: | ||
| raise Exception(f"unable to load module {pkg.name}") | ||
|
|
||
| mod = found.load_module(pkg.name) |
There was a problem hiding this comment.
@SamWilsn After some investigation, I have narrowed it down and it seems to me that these changes (L88 - L96) are causing a memory bloat while loading and running evm tools tests. Not entirely sure why though. Would you have any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This rips out sphinx and replaces it with docc.
Opening this as a draft because I'm still waiting on a few upstream PRs to merge.
Review Suggestions
I very strongly suggest doing this review one commit at a time. Several commits are just fixing formatting/flake8 problems that came up after updating the packages.
Cute Animal Picture