t8n: write output body to sys.stdout if specified #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Specifying
--output.body=stdout
doesn't write the body tosys.stdout
, but rather to a file called "stdout" in the directory specified by--output.basedir
, or the current working directory, if unspecified.Both the Geth and Nimbus t8n tools support specifying "stdout" to
--output.body
in order to write the txs rlp to the system's stdout. The geth, nimbus and ethereum-spec-evm share a common interface implementation in ethereum/execution-spec-tests; this is a discrepancy in their behavior.Related to Issue ethereum/execution-spec-tests#268.
How was it fixed?
Write the txs rlp to
sys.stdout
if--output.body=stdout
is specified, otherwise to the specified file. As previously, there is no output for the txs rlp if--output.body
is omitted.Cute Animal Picture