Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: Fix InteropClient Close routine. #426

Merged

Conversation

tyler-smith
Copy link
Contributor

Description

Fixes InteropClient shutdown behavior to call Close() on the underlying client instead of calling it on itself.

Additional context

Resolves a noticed issue with tests in the monorepo that wouldn't stop.

Metadata

Fixed as part of ethereum-optimism/optimism#12754

@tyler-smith tyler-smith requested a review from a team as a code owner October 31, 2024 09:37
@tyler-smith tyler-smith changed the title Interop sequencer check fix close interop: Fix InteropClient Close routine. Oct 31, 2024
@tyler-smith tyler-smith changed the base branch from optimism to interop-sequencer-check October 31, 2024 13:24
@protolambda protolambda merged commit 56eebc5 into interop-sequencer-check Oct 31, 2024
7 of 9 checks passed
@protolambda protolambda deleted the interop-sequencer-check-fix-close branch October 31, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants