-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to control DA required by blocks produced by the builder #421
Merged
sebastianst
merged 1 commit into
ethereum-optimism:optimism
from
roberto-bayardo:max-l1-size-limit
Oct 30, 2024
Merged
add ability to control DA required by blocks produced by the builder #421
sebastianst
merged 1 commit into
ethereum-optimism:optimism
from
roberto-bayardo:max-l1-size-limit
Oct 30, 2024
+132
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
changed the title
add ability to bound the max l1 data size
add ability to control DA required by blocks produced by the builder
Oct 29, 2024
roberto-bayardo
force-pushed
the
max-l1-size-limit
branch
7 times, most recently
from
October 29, 2024 18:09
15ecc21
to
5504bbf
Compare
mdehoog
reviewed
Oct 29, 2024
mdehoog
reviewed
Oct 29, 2024
roberto-bayardo
force-pushed
the
max-l1-size-limit
branch
from
October 29, 2024 18:35
5504bbf
to
6a7a1c0
Compare
mdehoog
reviewed
Oct 29, 2024
BrianBland
reviewed
Oct 29, 2024
roberto-bayardo
force-pushed
the
max-l1-size-limit
branch
3 times, most recently
from
October 29, 2024 19:57
ae8440d
to
9c45d47
Compare
sebastianst
reviewed
Oct 30, 2024
roberto-bayardo
force-pushed
the
max-l1-size-limit
branch
2 times, most recently
from
October 30, 2024 16:45
c55c02d
to
a650738
Compare
roberto-bayardo
force-pushed
the
max-l1-size-limit
branch
from
October 30, 2024 16:54
a650738
to
61c81a8
Compare
sebastianst
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a function that allows an external control mechanism to throttle data availability usage by limiting the total DA requirements of transactions/blocks.
Tests
Unit tests demonstrating setting the values results in transactions getting appropriately filtered from the payload.
Running these changes on base-sepolia where I ran some manual invocations of the tx-size filter and confirmed they were being appropriately delayed from block inclusion until the filter was disabled.
Additional context
Metadata