Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to control DA required by blocks produced by the builder #421

Merged

Conversation

roberto-bayardo
Copy link
Contributor

@roberto-bayardo roberto-bayardo commented Oct 29, 2024

Description

Adds a function that allows an external control mechanism to throttle data availability usage by limiting the total DA requirements of transactions/blocks.

Tests

Unit tests demonstrating setting the values results in transactions getting appropriately filtered from the payload.

Running these changes on base-sepolia where I ran some manual invocations of the tx-size filter and confirmed they were being appropriately delayed from block inclusion until the filter was disabled.

Additional context

Metadata

@roberto-bayardo roberto-bayardo requested a review from a team as a code owner October 29, 2024 14:59
@roberto-bayardo roberto-bayardo changed the title add ability to bound the max l1 data size add ability to control DA required by blocks produced by the builder Oct 29, 2024
@roberto-bayardo roberto-bayardo force-pushed the max-l1-size-limit branch 7 times, most recently from 15ecc21 to 5504bbf Compare October 29, 2024 18:09
eth/api_miner.go Outdated Show resolved Hide resolved
core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved
core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved
miner/payload_building_test.go Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the max-l1-size-limit branch 3 times, most recently from ae8440d to 9c45d47 Compare October 29, 2024 19:57
core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved
core/txpool/legacypool/legacypool.go Show resolved Hide resolved
core/txpool/legacypool/legacypool.go Show resolved Hide resolved
core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved
miner/payload_building_test.go Show resolved Hide resolved
miner/payload_building_test.go Outdated Show resolved Hide resolved
miner/payload_building_test.go Outdated Show resolved Hide resolved
miner/payload_building_test.go Outdated Show resolved Hide resolved
miner/worker.go Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the max-l1-size-limit branch 2 times, most recently from c55c02d to a650738 Compare October 30, 2024 16:45
miner/payload_building_test.go Show resolved Hide resolved
miner/payload_building_test.go Show resolved Hide resolved
@sebastianst sebastianst merged commit 4539f2d into ethereum-optimism:optimism Oct 30, 2024
4 of 5 checks passed
@roberto-bayardo roberto-bayardo deleted the max-l1-size-limit branch October 30, 2024 21:14
boyuan-chen pushed a commit to bobanetwork/op-geth that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants