Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pebble: Update to v1.1.2 #362

Merged
merged 1 commit into from
Aug 14, 2024
Merged

pebble: Update to v1.1.2 #362

merged 1 commit into from
Aug 14, 2024

Conversation

ajsutton
Copy link
Contributor

Description

Upstream uses v1.1.1 which has an API change reflected here, but we needed to stick with the older version for MIPS32 compatibility. Pebble v1.1.2 is just v1.1.1 with the MIPS compatibility fix so this moves us closer to upstream.

And ethereum/go-ethereum#30297 will hopefully update upstream geth to v1.1.2 of pebble and we will all live in joy and harmony forever and ever.

@ajsutton ajsutton requested a review from a team as a code owner August 14, 2024 00:43
Upstream uses v1.1.1 which has an API change reflected here, but we needed to stick with the older version for MIPS32 compatibility.
Pebble v1.1.2 is just v1.1.1 with the MIPS compatibility fix so this moves us closer to upstream.
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM

@sebastianst sebastianst merged commit b5cf845 into optimism Aug 14, 2024
10 checks passed
@sebastianst sebastianst deleted the aj/pebble-1.1.2 branch August 14, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants