Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes stack too deep error when compiling with the optimizer off #94

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

AmadiMichael
Copy link
Member

This PR fixes stack too deep error when compiling with the optimizer off. This is important to be able to run forge coverage and generate test coverage reports.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.89%. Comparing base (54e90a2) to head (c38cc21).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          27       27           
  Lines        4091     4091           
=======================================
  Hits         2532     2532           
  Misses       1427     1427           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, the things we do to appease the solidity compiler...

lgtm. once this is merged, please push an annotated v1.1.1 tag to this repository, and update the version of asterisc in the monorepo by updating the versions.json to have asterisc's version == v1.1.1.

@AmadiMichael AmadiMichael added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit 8c1db38 Nov 20, 2024
8 checks passed
@AmadiMichael AmadiMichael deleted the sc/stack-too-deep-fix branch November 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants