check out submodules in rvsol CI

ethereum-optimism · Nov 20, 2024 · 9d9ad00 · 9d9ad00
1 parent e6d3005
commit 9d9ad00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -35,6 +35,8 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
       - name: Install Golang
         uses: actions/setup-go@v5
         with:

diff --git a/rvsol/src/RISCV.sol b/rvsol/src/RISCV.sol
@@ -11,21 +11,15 @@ import { IBigStepper } from "@optimism/src/dispute/interfaces/IBigStepper.sol";
 /// @dev https://github.com/ethereum-optimism/asterisc
 contract RISCV is IBigStepper {
     /// @notice The preimage oracle contract.
-    IPreimageOracle internal immutable ORACLE;
+    IPreimageOracle public oracle;
 
     /// @notice The version of the contract.
     /// @custom:semver 1.1.0-rc.1
     string public constant version = "1.1.0-rc.1";
 
     /// @param _oracle The preimage oracle contract.
     constructor(IPreimageOracle _oracle) {
-        ORACLE = _oracle;
-    }
-
-    /// @notice Getter for the pre-image oracle contract.
-    /// @return oracle_ The pre-image oracle contract.
-    function oracle() external view returns (IPreimageOracle oracle_) {
-        oracle_ = ORACLE;
+        oracle = _oracle;
     }
 
     /// @inheritdoc IBigStepper