Fastify integration #192
Open
Fastify integration #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CircleCI failures are down to the 'superagent' version. I get this locally too. If I downgrade superagent to '4.1.0' the test suite runs. |
|
What is the state of this? |
I shall re-visit and see if the problem still exists. |
ethanresnick
reviewed
Apr 4, 2022
|
|
||
| // Set up a front controller, passing it controllers that'll be used | ||
| // to handle requests for API resources and for the auto-generated docs. | ||
| var Front = new API.httpStrategies.Express( |
There was a problem hiding this comment.
should be httpStrategies.Fastify
ethanresnick
reviewed
Apr 4, 2022
| * can set this option to false to have this code just pass on to Express. | ||
| */ | ||
| export default class FastifyStrategy extends Base { | ||
| constructor(apiController, docsController?, options?: HTTPStrategyOptions) { |
There was a problem hiding this comment.
Can we add type annotations here? I.e.,
constructor(apiController: APIController, docsController?: DocsController, options?: HTTPStrategyOptions)I realize the some of the other strategies doesn't have them, but they really should be there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a strategy for the Fastify web framework. #190