Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce QPS requirement to 100 #18928

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

serathius
Copy link
Member

@serathius serathius commented Nov 20, 2024

In last robustness meeting Nov 20 https://docs.google.com/document/d/1idZ_7tV6F18v223LyQ0WVUn9gXLSKyeLwYTdAgbjxpw/edit?usp=sharing, we identified that reducing QPS would reduce number of flakes from 10->2

We need a better way to monitor and track qps accross tests

@serathius
Copy link
Member Author

cc @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (4186283) to head (50be651).
Report is 23 commits behind head on main.

Current head 50be651 differs from pull request most recent head b85c6ba

Please upload reports for the commit b85c6ba to get more accurate results.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18928      +/-   ##
==========================================
+ Coverage   68.65%   68.72%   +0.06%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24413    24437      +24     
+ Misses       9715     9694      -21     
+ Partials     1430     1427       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4186283...b85c6ba. Read the comment docs.

---- 🚨 Try these New Features:

@serathius
Copy link
Member Author

And we imminently get a flake. We only got 147 QPS :(

Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius serathius changed the title Reduce QPS requirement to 150 Reduce QPS requirement to 100 Nov 20, 2024
@serathius
Copy link
Member Author

serathius commented Nov 20, 2024

Lowered it down to 100, I think we need to build up instead of getting cut off from the top

@serathius
Copy link
Member Author

/retest

@jmhbnz jmhbnz merged commit 0fcf6e8 into etcd-io:main Nov 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants