-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce QPS requirement to 100 #18928
Conversation
cc @jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @serathius
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18928 +/- ##
==========================================
+ Coverage 68.65% 68.72% +0.06%
==========================================
Files 420 420
Lines 35558 35558
==========================================
+ Hits 24413 24437 +24
+ Misses 9715 9694 -21
+ Partials 1430 1427 -3 Continue to review full report in Codecov by Sentry.
|
And we imminently get a flake. We only got 147 QPS :( |
Signed-off-by: Marek Siarkowicz <[email protected]>
efe42a8
to
b85c6ba
Compare
Lowered it down to 100, I think we need to build up instead of getting cut off from the top |
/retest |
In last robustness meeting Nov 20 https://docs.google.com/document/d/1idZ_7tV6F18v223LyQ0WVUn9gXLSKyeLwYTdAgbjxpw/edit?usp=sharing, we identified that reducing QPS would reduce number of flakes from 10->2
We need a better way to monitor and track qps accross tests