Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness duplicated puts 3 #18905

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

serathius
Copy link
Member

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (ee789c9) to head (7f788b0).
Report is 25 commits behind head on main.

Current head 7f788b0 differs from pull request most recent head 668834b

Please upload reports for the commit 668834b to get more accurate results.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18905      +/-   ##
==========================================
+ Coverage   68.71%   68.72%   +0.01%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24433    24439       +6     
+ Misses       9695     9691       -4     
+ Partials     1430     1428       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee789c9...668834b. Read the comment docs.

---- 🚨 Try these New Features:

@serathius serathius force-pushed the robustness-duplicated-puts-3 branch 2 times, most recently from 9f11f87 to 96c47e8 Compare November 16, 2024 23:14
@serathius serathius marked this pull request as ready for review November 17, 2024 20:53
@serathius
Copy link
Member Author

@jmhbnz
Copy link
Member

jmhbnz commented Nov 18, 2024

/retest

@serathius
Copy link
Member Author

ping @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz requested a review from fuweid November 24, 2024 10:11
@serathius serathius merged commit fe45307 into etcd-io:main Nov 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants