Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es_extended/server/modules/commands): add /setdim cmd #1526

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

Kenshiin13
Copy link
Contributor

Description

This PR resolves an issue where teleporting to another player or bringing a player to you as an admin did not ensure that both players were in the same dimension. This behavior is counterintuitive, as admins would expect the player to appear directly in front of them, not in a different dimension. To address this, the commands now automatically set both players to the same dimension during teleportation. Additionally, a /setdim admin command has been added to allow manual dimension adjustments if necessary.

Key Changes

  • Added the /setdim <targetSrc> <targetDim> admin command, allowing admins to manually set a player's dimension.
  • Updated the /goto and /bring admin commands to ensure both players are placed in the same dimension during teleportation.

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@Kenshiin13 Kenshiin13 self-assigned this Dec 6, 2024
Mycroft-Studios
Mycroft-Studios previously approved these changes Dec 6, 2024
@Kenshiin13 Kenshiin13 merged commit 5478165 into dev Dec 6, 2024
3 checks passed
@Kenshiin13 Kenshiin13 deleted the fix-tp-cmds branch December 6, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Next Update
Development

Successfully merging this pull request may close these issues.

2 participants