Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support class field declarations(add support for property without value). #467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion escodegen.js
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,8 @@

for (i = 0, iz = stmt.body.length; i < iz; ++i) {
result.push(indent);
result.push(that.generateExpression(stmt.body[i], Precedence.Sequence, E_TTT));
var flag = E_TTT | (i === iz - 1 ? F_SEMICOLON_OPT : 0)
result.push(that.generateExpression(stmt.body[i], Precedence.Sequence, flag));
if (i + 1 < iz) {
result.push(newline);
}
Expand Down Expand Up @@ -2161,6 +2162,28 @@
return join(result, fragment);
},

PrivateIdentifier: function (expr, precedence, flags) {
return toSourceNodeWhenNeeded('#' + expr.name, expr);
},
PropertyDefinition: function (expr, precedence, flags) {
var keywords = [];
if (expr.static) {
keywords.push('static');
}
// null for property without value
var assign = expr.value !== null ? [
space,
'=',
space,
this.generateExpression(expr.value, Precedence.Assignment, E_TTT)
] : []
return join(keywords, [].concat(
this.generatePropertyKey(expr.key, expr.computed),
assign,
this.semicolon(flags)
));
},

Property: function (expr, precedence, flags) {
if (expr.kind === 'get' || expr.kind === 'set') {
return [
Expand Down
99 changes: 99 additions & 0 deletions test/compare-acorn-es2022.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
/*
Copyright (C) 2012-2013 Yusuke Suzuki <[email protected]>
Copyright (C) 2020 Apple Inc. All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

'use strict';

var fs = require('fs'),
acorn = require('acorn'),
escodegen = require('./loader'),
chai = require('chai'),
chaiExclude = require('chai-exclude'),
expect = chai.expect;

chai.use(chaiExclude);

function test(code, expected) {
var expectedTree, actual, actualTree, options;

options = {
ranges: false,
locations: false,
ecmaVersion: 2022,
};

expectedTree = acorn.parse(code, options);

// for UNIX text comment
actual = escodegen.generate(expectedTree) + "\n";
actualTree = acorn.parse(actual, options);

console.dir(expectedTree, { depth: null });
console.dir(actualTree, { depth: null });

expect(actual).to.be.equal(expected);
expect(actualTree).excludingEvery(['start', 'end', 'raw']).to.deep.equal(expectedTree);
}

function testMin(code, expected) {
var expectedTree, actual, actualTree, options;

options = {
ranges: false,
locations: false,
ecmaVersion: 2022,
};

expectedTree = acorn.parse(code, options);

// for UNIX text comment
actual = escodegen.generate(expectedTree, {
format: escodegen.FORMAT_MINIFY,
raw: false
}).replace(/[\n\r]$/, '') + '\n';
actualTree = acorn.parse(actual, options);

expect(actual).to.be.equal(expected);
expect(actualTree).excludingEvery(['start', 'end', 'raw']).to.deep.equal(expectedTree);
}

describe('compare acorn es2022 test', function () {
fs.readdirSync(__dirname + '/compare-acorn-es2022').sort().forEach(function(file) {
var code, expected, exp, min;
if (/\.js$/.test(file) && !/expected\.js$/.test(file) && !/expected\.min\.js$/.test(file)) {
it(file, function () {
exp = file.replace(/\.js$/, '.expected.js');
min = file.replace(/\.js$/, '.expected.min.js');
code = fs.readFileSync(__dirname + '/compare-acorn-es2022/' + file, 'utf-8');
expected = fs.readFileSync(__dirname + '/compare-acorn-es2022/' + exp, 'utf-8');
test(code, expected);
if (fs.existsSync(__dirname + '/compare-acorn-es2022/' + min)) {
expected = fs.readFileSync(__dirname + '/compare-acorn-es2022/' + min, 'utf-8');
testMin(code, expected);
}
});
}
});
});
/* vim: set sw=4 ts=4 et tw=80 : */
10 changes: 10 additions & 0 deletions test/compare-acorn-es2022/class-field-declarations.expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
class FieldDeclarations {
noValue;
member = 1;
['non-identifier'] = 18;
[Symbol.iterator] = 10;
#privateMember = 2;
static #STATIC = 3;
static STATIC = 4;
static [1 + 2] = 4;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
class FieldDeclarations{noValue;member=1;['non-identifier']=18;[Symbol.iterator]=10;#privateMember=2;static#STATIC=3;static STATIC=4;static[1+2]=4}
13 changes: 13 additions & 0 deletions test/compare-acorn-es2022/class-field-declarations.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
class FieldDeclarations{
noValue
member = 1;

["non-identifier"] = 18;
[Symbol.iterator] = 10;

#privateMember = 2

static #STATIC = 3
static STATIC = 4
static [1 + 2] = 4
}