Fix flooding Log/Debug tab with errormessages when Host ist not reachable #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborovsky
approved these changes
Nov 1, 2022
|
Is it possible to update the public npm package that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressing Issues #12 #9
Connection state is visible from the ui (indicated by the red dot on the node).
I extended the message besides the red dot to contain the error message.
Therefore there is no reason anymore to flood the logs with the connection errors.
Alternatively one could of course throw the errors on the -in and -out nodes, to make them catchable. But I think disconnected receivers are more like a norm and it is to be expected that one could not always connect to them